Implement Lift using interners instead of in_arena #67791
Conversation
rust-highfive
added
the
S-waiting-on-review
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
| @@ -137,6 +137,20 @@ impl<K: Eq + Hash + Copy> ShardedHashMap<K, ()> { | |||
| } | |||
| } | |||
|
|
|||
| pub unsafe trait IntoPointer { | |||
There was a problem hiding this comment.
Documenting the proof obligations would be good.
There was a problem hiding this comment.
I'll just make it safe instead =P
|
☀️ Try build successful - checks-azure |
|
Queued 5071cca with parent 0ec3706, future comparison URL. |
|
Finished benchmarking try commit 5071cca, comparison URL. |
|
☔ The latest upstream changes (presumably #68115) made this pull request unmergeable. Please resolve the merge conflicts. |
| @@ -123,6 +123,9 @@ macro_rules! arena_types { | |||
| [few] inferred_outlives_crate: rustc::ty::CratePredicatesMap<'tcx>, | |||
| [] upvars: rustc_data_structures::fx::FxIndexMap<rustc_hir::HirId, rustc_hir::Upvar>, | |||
|
|
|||
| // Interned types | |||
| [] tys: rustc::ty::TyS<$tcx>, | |||
There was a problem hiding this comment.
Huh, so we're not using the DroplessArena for these anymore?
There was a problem hiding this comment.
We do, but TyS is not Copy, so we have to declare it.
| assoc_name: ast::Ident, | ||
| span: Span, | ||
| is_equality: Option<String>, | ||
| is_equality: impl Fn() -> Option<String>, |
There was a problem hiding this comment.
Am I missing something, or are the changes in this file unrelated?
There was a problem hiding this comment.
I stumbled into this since I broke Lift while working on this PR. There's more cases still where we print types without using them.
|
r=me with #67791 (comment) explained or resolved |
|
@bors r+ |
|
📌 Commit f4968c8 has been approved by |
bors
added
S-waiting-on-bors
Rollup of 4 pull requests Successful merges: - #66564 (Document unsafe blocks in core::{cell, str, sync}) - #67791 (Implement Lift using interners instead of in_arena) - #68278 ([self-profiler] Add example to `-Z help` to turn on query key recording) - #68300 (Allow added string.insert benchmarks to compile) Failed merges: r? @ghost
r? @eddyb
cc @cjgillot