Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "use $crate" a hard error #67775

Merged
merged 8 commits into from
Jan 4, 2020
Merged

Make "use $crate" a hard error #67775

merged 8 commits into from
Jan 4, 2020

Conversation

mental32
Copy link
Contributor

@mental32 mental32 commented Jan 1, 2020

Closes #37390

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 1, 2020
@Dylan-DPC-zz
Copy link

r? @Dylan-DPC

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-01T12:45:02.3177033Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-01T12:45:02.3395788Z ##[command]git config gc.auto 0
2020-01-01T12:45:02.3451038Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-01T12:45:02.3502691Z ##[command]git config --get-all http.proxy
2020-01-01T12:45:02.3639595Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67775/merge:refs/remotes/pull/67775/merge
---
2020-01-01T13:48:53.6956348Z .................................................................................................... 1500/9467
2020-01-01T13:48:59.7013307Z .................................................................................................... 1600/9467
2020-01-01T13:49:04.8031750Z .................................................................................................... 1700/9467
2020-01-01T13:49:14.7134941Z .................................................................................................... 1800/9467
2020-01-01T13:49:23.2548881Z i................................................................................................... 1900/9467
2020-01-01T13:49:30.1706772Z ......................................................................................iiiii......... 2000/9467
2020-01-01T13:49:52.9947588Z .................................................................................................... 2200/9467
2020-01-01T13:49:55.4580414Z .................................................................................................... 2300/9467
2020-01-01T13:49:58.0311406Z .................................................................................................... 2400/9467
2020-01-01T13:50:04.3761844Z .................................................................................................... 2500/9467
---
2020-01-01T13:53:12.0544527Z .................i...............i.................................................................. 4900/9467
2020-01-01T13:53:22.4277320Z .................................................................................................... 5000/9467
2020-01-01T13:53:28.8934008Z ..............................................................i..................................... 5100/9467
2020-01-01T13:53:38.0055752Z .................................................................................................... 5200/9467
2020-01-01T13:53:45.3624128Z .............................ii.ii...........i...................................................... 5300/9467
2020-01-01T13:53:55.1839887Z .................................................................................................... 5500/9467
2020-01-01T13:54:05.8027696Z .................................................................................................... 5600/9467
2020-01-01T13:54:13.0369687Z ............i....................................................................................... 5700/9467
2020-01-01T13:54:19.4726448Z .................................................................................................... 5800/9467
2020-01-01T13:54:19.4726448Z .................................................................................................... 5800/9467
2020-01-01T13:54:30.6827219Z .................................................................................................... 5900/9467
2020-01-01T13:54:42.8463577Z ii...i..ii...........i.............................................................................. 6000/9467
2020-01-01T13:55:01.2148113Z .................................................................................................... 6200/9467
2020-01-01T13:55:08.7639944Z .................................................................................................... 6300/9467
2020-01-01T13:55:08.7639944Z .................................................................................................... 6300/9467
2020-01-01T13:55:26.0501928Z ...........................i..ii.................................................................... 6400/9467
2020-01-01T13:55:47.2233501Z .................................................................................................... 6600/9467
2020-01-01T13:55:49.4313574Z ...i................................................................................................ 6700/9467
2020-01-01T13:55:51.8748932Z .................................................................................................... 6800/9467
2020-01-01T13:55:54.5494132Z ..i................................................................................................. 6900/9467
---
2020-01-01T13:57:37.5747751Z .................................................................................................... 7500/9467
2020-01-01T13:57:42.6395102Z .................................................................................................... 7600/9467
2020-01-01T13:57:48.4800909Z .................................................................................................... 7700/9467
2020-01-01T13:57:59.1127263Z .................................................................................................... 7800/9467
2020-01-01T13:58:07.1177261Z .....................................iiii........................................................... 7900/9467
2020-01-01T13:58:22.5166315Z .................................................................................................... 8100/9467
2020-01-01T13:58:31.4894355Z .................................................................................................... 8200/9467
2020-01-01T13:58:46.3146068Z .................................................................................................... 8300/9467
2020-01-01T13:58:54.5628916Z .................................................................................................... 8400/9467
---
2020-01-01T14:00:55.6401655Z 
2020-01-01T14:00:55.6402255Z ---- [ui] ui/dollar-crate/dollar-crate-is-keyword.rs stdout ----
2020-01-01T14:00:55.6402531Z diff of stderr:
2020-01-01T14:00:55.6402569Z 
2020-01-01T14:00:55.6402611Z 16 LL | m!();
2020-01-01T14:00:55.6403360Z 18 
2020-01-01T14:00:55.6403586Z - warning: `$crate` may not be imported
2020-01-01T14:00:55.6403635Z + error: `$crate` may not be imported
2020-01-01T14:00:55.6403871Z 20   --> $DIR/dollar-crate-is-keyword.rs:9:9
2020-01-01T14:00:55.6403871Z 20   --> $DIR/dollar-crate-is-keyword.rs:9:9
2020-01-01T14:00:55.6403918Z 21    |
2020-01-01T14:00:55.6403960Z 22 LL |         use $crate; // OK
2020-01-01T14:00:55.6404045Z 24 ...
2020-01-01T14:00:55.6404045Z 24 ...
2020-01-01T14:00:55.6404085Z 25 LL | m!();
2020-01-01T14:00:55.6404701Z -    |
2020-01-01T14:00:55.6404701Z -    |
2020-01-01T14:00:55.6405005Z -    = note: `use $crate;` was erroneously allowed and will become a hard error in a future release
2020-01-01T14:00:55.6405277Z - warning: `$crate` may not be imported
2020-01-01T14:00:55.6405352Z + error: `$crate` may not be imported
2020-01-01T14:00:55.6405580Z 31   --> $DIR/dollar-crate-is-keyword.rs:11:9
2020-01-01T14:00:55.6405625Z 32    |
2020-01-01T14:00:55.6405625Z 32    |
2020-01-01T14:00:55.6405684Z 33 LL |         use $crate as $crate;
2020-01-01T14:00:55.6405752Z 35 ...
2020-01-01T14:00:55.6405752Z 35 ...
2020-01-01T14:00:55.6405793Z 36 LL | m!();
2020-01-01T14:00:55.6406206Z -    |
2020-01-01T14:00:55.6406206Z -    |
2020-01-01T14:00:55.6406476Z -    = note: `use $crate;` was erroneously allowed and will become a hard error in a future release
2020-01-01T14:00:55.6406756Z - error: aborting due to 2 previous errors
2020-01-01T14:00:55.6406814Z + error: aborting due to 4 previous errors
2020-01-01T14:00:55.6406869Z 42 
2020-01-01T14:00:55.6406907Z 43 
2020-01-01T14:00:55.6406907Z 43 
2020-01-01T14:00:55.6406932Z 
2020-01-01T14:00:55.6406958Z 
2020-01-01T14:00:55.6407019Z The actual stderr differed from the expected stderr.
2020-01-01T14:00:55.6407347Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dollar-crate/dollar-crate-is-keyword/dollar-crate-is-keyword.stderr
2020-01-01T14:00:55.6407613Z To update references, rerun the tests and pass the `--bless` flag
2020-01-01T14:00:55.6407952Z To only update this specific test, also pass `--test-args dollar-crate/dollar-crate-is-keyword.rs`
2020-01-01T14:00:55.6408039Z error: 1 errors occurred comparing output.
2020-01-01T14:00:55.6408087Z status: exit code: 1
2020-01-01T14:00:55.6408087Z status: exit code: 1
2020-01-01T14:00:55.6409012Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dollar-crate/dollar-crate-is-keyword" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dollar-crate/dollar-crate-is-keyword/auxiliary" "-A" "unused"
2020-01-01T14:00:55.6409384Z ------------------------------------------
2020-01-01T14:00:55.6409420Z 
2020-01-01T14:00:55.6409678Z ------------------------------------------
2020-01-01T14:00:55.6409726Z stderr:
2020-01-01T14:00:55.6409726Z stderr:
2020-01-01T14:00:55.6409962Z ------------------------------------------
2020-01-01T14:00:55.6410014Z error: expected identifier, found reserved identifier `$crate`
2020-01-01T14:00:55.6410320Z   --> /checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs:6:20
2020-01-01T14:00:55.6410374Z    |
2020-01-01T14:00:55.6410427Z LL |             struct $crate {} //~ ERROR expected identifier, found reserved identifier `$crate`
2020-01-01T14:00:55.6410553Z ...
2020-01-01T14:00:55.6410553Z ...
2020-01-01T14:00:55.6410596Z LL | m!();
2020-01-01T14:00:55.6411035Z 
2020-01-01T14:00:55.6411083Z error: expected identifier, found reserved identifier `$crate`
2020-01-01T14:00:55.6411373Z   --> /checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs:11:23
2020-01-01T14:00:55.6411424Z    |
2020-01-01T14:00:55.6411424Z    |
2020-01-01T14:00:55.6411478Z LL |         use $crate as $crate; //~ ERROR expected identifier, found reserved identifier `$crate`
2020-01-01T14:00:55.6411599Z ...
2020-01-01T14:00:55.6411599Z ...
2020-01-01T14:00:55.6411641Z LL | m!();
2020-01-01T14:00:55.6412013Z 
2020-01-01T14:00:55.6412059Z error: `$crate` may not be imported
2020-01-01T14:00:55.6412361Z   --> /checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs:9:9
2020-01-01T14:00:55.6412427Z    |
2020-01-01T14:00:55.6412427Z    |
2020-01-01T14:00:55.6412472Z LL |         use $crate; // OK
2020-01-01T14:00:55.6412569Z ...
2020-01-01T14:00:55.6412569Z ...
2020-01-01T14:00:55.6412630Z LL | m!();
2020-01-01T14:00:55.6413935Z 
2020-01-01T14:00:55.6413979Z error: `$crate` may not be imported
2020-01-01T14:00:55.6414265Z   --> /checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs:11:9
2020-01-01T14:00:55.6414313Z    |
2020-01-01T14:00:55.6414313Z    |
2020-01-01T14:00:55.6414363Z LL |         use $crate as $crate; //~ ERROR expected identifier, found reserved identifier `$crate`
2020-01-01T14:00:55.6414470Z ...
2020-01-01T14:00:55.6414470Z ...
2020-01-01T14:00:55.6414510Z LL | m!();
2020-01-01T14:00:55.6415644Z 
2020-01-01T14:00:55.6415692Z error: aborting due to 4 previous errors
2020-01-01T14:00:55.6415721Z 
2020-01-01T14:00:55.6415746Z 
2020-01-01T14:00:55.6415746Z 
2020-01-01T14:00:55.6416043Z ------------------------------------------
2020-01-01T14:00:55.6416077Z 
2020-01-01T14:00:55.6416102Z 
2020-01-01T14:00:55.6416339Z ---- [ui] ui/imports/import-crate-var.rs stdout ----
2020-01-01T14:00:55.6416388Z 
2020-01-01T14:00:55.6417241Z error: test compilation failed although it shouldn't!
2020-01-01T14:00:55.6417311Z status: exit code: 1
2020-01-01T14:00:55.6418967Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/imports/import-crate-var.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/import-crate-var" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/import-crate-var/auxiliary" "-A" "unused"
2020-01-01T14:00:55.6420000Z ------------------------------------------
2020-01-01T14:00:55.6420051Z 
2020-01-01T14:00:55.6420281Z ------------------------------------------
2020-01-01T14:00:55.6420928Z stderr:
---
2020-01-01T14:00:55.6430342Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:385:22
2020-01-01T14:00:55.6430419Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2020-01-01T14:00:55.6449224Z 
2020-01-01T14:00:55.6449764Z 
2020-01-01T14:00:55.6451998Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-01-01T14:00:55.6452585Z 
2020-01-01T14:00:55.6453625Z 
2020-01-01T14:00:55.6453948Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-01-01T14:00:55.6454114Z Build completed unsuccessfully in 1:09:11
2020-01-01T14:00:55.6454114Z Build completed unsuccessfully in 1:09:11
2020-01-01T14:00:55.6516973Z == clock drift check ==
2020-01-01T14:00:55.6534413Z   local time: Wed Jan  1 14:00:55 UTC 2020
2020-01-01T14:00:55.9391060Z   network time: Wed, 01 Jan 2020 14:00:55 GMT
2020-01-01T14:00:55.9392943Z == end clock drift check ==
2020-01-01T14:00:57.1437696Z 
2020-01-01T14:00:57.1552106Z ##[error]Bash exited with code '1'.
2020-01-01T14:00:57.1588944Z ##[section]Starting: Checkout
2020-01-01T14:00:57.1590838Z ==============================================================================
2020-01-01T14:00:57.1590894Z Task         : Get sources
2020-01-01T14:00:57.1590941Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-02T06:39:44.5104726Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-02T06:39:44.5327178Z ##[command]git config gc.auto 0
2020-01-02T06:39:44.5412820Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-02T06:39:44.5479056Z ##[command]git config --get-all http.proxy
2020-01-02T06:39:44.5655318Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67775/merge:refs/remotes/pull/67775/merge
---
2020-01-02T07:39:38.8006520Z .................................................................................................... 1500/9468
2020-01-02T07:39:44.6288002Z .................................................................................................... 1600/9468
2020-01-02T07:39:49.5472265Z .................................................................................................... 1700/9468
2020-01-02T07:39:58.9526682Z .................................................................................................... 1800/9468
2020-01-02T07:40:07.0998114Z .i.................................................................................................. 1900/9468
2020-01-02T07:40:13.7840464Z .......................................................................................iiiii........ 2000/9468
2020-01-02T07:40:35.4971127Z .................................................................................................... 2200/9468
2020-01-02T07:40:37.8365432Z .................................................................................................... 2300/9468
2020-01-02T07:40:40.3106821Z .................................................................................................... 2400/9468
2020-01-02T07:40:46.3594863Z .................................................................................................... 2500/9468
2020-01-02T07:40:46.3594863Z .................................................................................................... 2500/9468
2020-01-02T07:41:06.5226624Z .................................................................................................... 2600/9468
2020-01-02T07:41:09.3579318Z .................................................................................................... 2700/9468
2020-01-02T07:41:20.0878912Z ...............................................................i.................................... 2800/9468
2020-01-02T07:41:26.1129490Z .................................................................................................... 2900/9468
2020-01-02T07:41:34.0825739Z .....................................................................................i.............. 3000/9468
2020-01-02T07:41:40.3520949Z .................................................................................................... 3100/9468
2020-01-02T07:41:48.1342257Z .................................................................................................... 3200/9468
2020-01-02T07:41:53.5356873Z F....................................................................ii............................. 3300/9468
2020-01-02T07:42:09.6036716Z .................................................................................................... 3500/9468
2020-01-02T07:42:18.0825610Z ............................................................i....................................... 3600/9468
2020-01-02T07:42:23.5093256Z .......i............................................................................................ 3700/9468
2020-01-02T07:42:29.6523818Z .................................................................................................... 3800/9468
---
2020-01-02T07:43:45.0493849Z ..................i...............i................................................................. 4900/9468
2020-01-02T07:43:54.9998537Z .................................................................................................... 5000/9468
2020-01-02T07:44:00.9218156Z ...............................................................i.................................... 5100/9468
2020-01-02T07:44:09.1758219Z .................................................................................................... 5200/9468
2020-01-02T07:44:16.5791096Z ..............................ii.ii...........i..................................................... 5300/9468
2020-01-02T07:44:25.8860809Z .................................................................................................... 5500/9468
2020-01-02T07:44:35.9652979Z .................................................................................................... 5600/9468
2020-01-02T07:44:43.0572664Z .............i...................................................................................... 5700/9468
2020-01-02T07:44:49.3163431Z .................................................................................................... 5800/9468
2020-01-02T07:44:49.3163431Z .................................................................................................... 5800/9468
2020-01-02T07:45:00.1656458Z .................................................................................................... 5900/9468
2020-01-02T07:45:12.0103708Z .ii...i..ii...........i............................................................................. 6000/9468
2020-01-02T07:45:29.5894512Z .................................................................................................... 6200/9468
2020-01-02T07:45:36.8905571Z .................................................................................................... 6300/9468
2020-01-02T07:45:36.8905571Z .................................................................................................... 6300/9468
2020-01-02T07:45:55.3847028Z ............................i..ii................................................................... 6400/9468
2020-01-02T07:46:15.5000803Z .................................................................................................... 6600/9468
2020-01-02T07:46:17.5773806Z ...i................................................................................................ 6700/9468
2020-01-02T07:46:19.8642053Z .................................................................................................... 6800/9468
2020-01-02T07:46:22.3526095Z ...i................................................................................................ 6900/9468
---
2020-01-02T07:47:58.4554909Z .................................................................................................... 7500/9468
2020-01-02T07:48:03.1025667Z .................................................................................................... 7600/9468
2020-01-02T07:48:08.4652468Z .................................................................................................... 7700/9468
2020-01-02T07:48:18.5091159Z .................................................................................................... 7800/9468
2020-01-02T07:48:25.9685493Z .....................................iiii........................................................... 7900/9468
2020-01-02T07:48:40.5404810Z .................................................................................................... 8100/9468
2020-01-02T07:48:49.0088968Z .................................................................................................... 8200/9468
2020-01-02T07:49:03.0369438Z .................................................................................................... 8300/9468
2020-01-02T07:49:11.0560171Z .................................................................................................... 8400/9468
---
2020-01-02T07:51:03.8688876Z 10 error: expected identifier, found reserved identifier `$crate`
2020-01-02T07:51:03.8689084Z -   --> $DIR/dollar-crate-is-keyword.rs:11:23
2020-01-02T07:51:03.8689326Z +   --> $DIR/dollar-crate-is-keyword.rs:10:23
2020-01-02T07:51:03.8689376Z 12    |
2020-01-02T07:51:03.8689417Z 13 LL |         use $crate as $crate;
2020-01-02T07:51:03.8689740Z 
2020-01-02T07:51:03.8689799Z 19 error: `$crate` may not be imported
2020-01-02T07:51:03.8690080Z 20   --> $DIR/dollar-crate-is-keyword.rs:9:9
2020-01-02T07:51:03.8690241Z 21    |
2020-01-02T07:51:03.8690241Z 21    |
2020-01-02T07:51:03.8690473Z - LL |         use $crate;
2020-01-02T07:51:03.8690655Z + LL |         use $crate; // ERROR `$crate` may not be imported
2020-01-02T07:51:03.8690761Z 24 ...
2020-01-02T07:51:03.8690761Z 24 ...
2020-01-02T07:51:03.8690841Z 25 LL | m!();
2020-01-02T07:51:03.8691108Z 26    | ----- in this macro invocation
2020-01-02T07:51:03.8691661Z -    |
2020-01-02T07:51:03.8691833Z 28 
2020-01-02T07:51:03.8693254Z 29 error: `$crate` may not be imported
2020-01-02T07:51:03.8693254Z 29 error: `$crate` may not be imported
2020-01-02T07:51:03.8694506Z -   --> $DIR/dollar-crate-is-keyword.rs:11:9
2020-01-02T07:51:03.8694802Z +   --> $DIR/dollar-crate-is-keyword.rs:10:9
2020-01-02T07:51:03.8695004Z 31    |
2020-01-02T07:51:03.8695099Z 32 LL |         use $crate as $crate;
2020-01-02T07:51:03.8695198Z 
2020-01-02T07:51:03.8695289Z 34 ...
2020-01-02T07:51:03.8695289Z 34 ...
2020-01-02T07:51:03.8695333Z 35 LL | m!();
2020-01-02T07:51:03.8695946Z -    |
2020-01-02T07:51:03.8696141Z 38 
2020-01-02T07:51:03.8696216Z 39 error: aborting due to 4 previous errors
2020-01-02T07:51:03.8696300Z 40 
2020-01-02T07:51:03.8696300Z 40 
2020-01-02T07:51:03.8696350Z 
2020-01-02T07:51:03.8696396Z 
2020-01-02T07:51:03.8696466Z The actual stderr differed from the expected stderr.
2020-01-02T07:51:03.8696871Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dollar-crate/dollar-crate-is-keyword/dollar-crate-is-keyword.stderr
2020-01-02T07:51:03.8697150Z To update references, rerun the tests and pass the `--bless` flag
2020-01-02T07:51:03.8697766Z To only update this specific test, also pass `--test-args dollar-crate/dollar-crate-is-keyword.rs`
2020-01-02T07:51:03.8698260Z error: 1 errors occurred comparing output.
2020-01-02T07:51:03.8698351Z status: exit code: 1
2020-01-02T07:51:03.8698351Z status: exit code: 1
2020-01-02T07:51:03.8699426Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dollar-crate/dollar-crate-is-keyword" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dollar-crate/dollar-crate-is-keyword/auxiliary" "-A" "unused"
2020-01-02T07:51:03.8700512Z ------------------------------------------
2020-01-02T07:51:03.8700557Z 
2020-01-02T07:51:03.8700816Z ------------------------------------------
2020-01-02T07:51:03.8701006Z stderr:
2020-01-02T07:51:03.8701006Z stderr:
2020-01-02T07:51:03.8701296Z ------------------------------------------
2020-01-02T07:51:03.8701366Z error: expected identifier, found reserved identifier `$crate`
2020-01-02T07:51:03.8701760Z   --> /checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs:6:20
2020-01-02T07:51:03.8701950Z    |
2020-01-02T07:51:03.8702024Z LL |             struct $crate {} //~ ERROR expected identifier, found reserved identifier `$crate`
2020-01-02T07:51:03.8702240Z ...
2020-01-02T07:51:03.8702240Z ...
2020-01-02T07:51:03.8702310Z LL | m!();
2020-01-02T07:51:03.8702586Z 
2020-01-02T07:51:03.8702644Z error: expected identifier, found reserved identifier `$crate`
2020-01-02T07:51:03.8703947Z   --> /checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs:10:23
2020-01-02T07:51:03.8704195Z    |
2020-01-02T07:51:03.8704195Z    |
2020-01-02T07:51:03.8704283Z LL |         use $crate as $crate; //~ ERROR expected identifier, found reserved identifier `$crate`
2020-01-02T07:51:03.8704407Z ...
2020-01-02T07:51:03.8704407Z ...
2020-01-02T07:51:03.8704556Z LL | m!();
2020-01-02T07:51:03.8704896Z 
2020-01-02T07:51:03.8704942Z error: `$crate` may not be imported
2020-01-02T07:51:03.8705351Z   --> /checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs:9:9
2020-01-02T07:51:03.8705546Z    |
2020-01-02T07:51:03.8705546Z    |
2020-01-02T07:51:03.8705638Z LL |         use $crate; // ERROR `$crate` may not be imported
2020-01-02T07:51:03.8705751Z ...
2020-01-02T07:51:03.8705751Z ...
2020-01-02T07:51:03.8705806Z LL | m!();
2020-01-02T07:51:03.8706083Z 
2020-01-02T07:51:03.8706155Z error: `$crate` may not be imported
2020-01-02T07:51:03.8706590Z   --> /checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs:10:9
2020-01-02T07:51:03.8706765Z    |
2020-01-02T07:51:03.8706765Z    |
2020-01-02T07:51:03.8706866Z LL |         use $crate as $crate; //~ ERROR expected identifier, found reserved identifier `$crate`
2020-01-02T07:51:03.8707007Z ...
2020-01-02T07:51:03.8707007Z ...
2020-01-02T07:51:03.8707070Z LL | m!();
2020-01-02T07:51:03.8707597Z 
2020-01-02T07:51:03.8707656Z error: aborting due to 4 previous errors
2020-01-02T07:51:03.8707683Z 
2020-01-02T07:51:03.8707708Z 
2020-01-02T07:51:03.8707708Z 
2020-01-02T07:51:03.8707903Z ------------------------------------------
2020-01-02T07:51:03.8707933Z 
2020-01-02T07:51:03.8707974Z 
2020-01-02T07:51:03.8708345Z ---- [ui] ui/imports/import-crate-var.rs stdout ----
2020-01-02T07:51:03.8708498Z 
2020-01-02T07:51:03.8708829Z error: test compilation failed although it shouldn't!
2020-01-02T07:51:03.8708887Z status: exit code: 1
2020-01-02T07:51:03.8709805Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/imports/import-crate-var.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/import-crate-var" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/import-crate-var/auxiliary" "-A" "unused"
2020-01-02T07:51:03.8710317Z ------------------------------------------
2020-01-02T07:51:03.8710482Z 
2020-01-02T07:51:03.8710767Z ------------------------------------------
2020-01-02T07:51:03.8711071Z stderr:
---
2020-01-02T07:51:03.8722543Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:385:22
2020-01-02T07:51:03.8722642Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2020-01-02T07:51:03.8737011Z 
2020-01-02T07:51:03.8737134Z 
2020-01-02T07:51:03.8739218Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-01-02T07:51:03.8739504Z 
2020-01-02T07:51:03.8739532Z 
2020-01-02T07:51:03.8752663Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-01-02T07:51:03.8753477Z Build completed unsuccessfully in 1:04:49
2020-01-02T07:51:03.8753477Z Build completed unsuccessfully in 1:04:49
2020-01-02T07:51:03.8806866Z == clock drift check ==
2020-01-02T07:51:03.8825000Z   local time: Thu Jan  2 07:51:03 UTC 2020
2020-01-02T07:51:04.1678853Z   network time: Thu, 02 Jan 2020 07:51:04 GMT
2020-01-02T07:51:04.1686856Z == end clock drift check ==
2020-01-02T07:51:05.0269608Z 
2020-01-02T07:51:05.0394853Z ##[error]Bash exited with code '1'.
2020-01-02T07:51:05.0443916Z ##[section]Starting: Checkout
2020-01-02T07:51:05.0445673Z ==============================================================================
2020-01-02T07:51:05.0445729Z Task         : Get sources
2020-01-02T07:51:05.0445780Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-02T08:17:07.1554685Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-02T08:17:08.1917463Z ##[command]git config gc.auto 0
2020-01-02T08:17:08.1920765Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-02T08:17:08.1923180Z ##[command]git config --get-all http.proxy
2020-01-02T08:17:08.1926484Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67775/merge:refs/remotes/pull/67775/merge
---
2020-01-02T09:17:03.8099489Z .................................................................................................... 1500/9468
2020-01-02T09:17:09.7420840Z .................................................................................................... 1600/9468
2020-01-02T09:17:14.7179286Z .................................................................................................... 1700/9468
2020-01-02T09:17:24.3379697Z .................................................................................................... 1800/9468
2020-01-02T09:17:32.6456996Z .i.................................................................................................. 1900/9468
2020-01-02T09:17:39.5289288Z .......................................................................................iiiii........ 2000/9468
2020-01-02T09:18:01.7320615Z .................................................................................................... 2200/9468
2020-01-02T09:18:04.1146157Z .................................................................................................... 2300/9468
2020-01-02T09:18:06.6167022Z .................................................................................................... 2400/9468
2020-01-02T09:18:12.8081854Z .................................................................................................... 2500/9468
2020-01-02T09:18:12.8081854Z .................................................................................................... 2500/9468
2020-01-02T09:18:32.5669919Z .................................................................................................... 2600/9468
2020-01-02T09:18:35.3957778Z .................................................................................................... 2700/9468
2020-01-02T09:18:45.9764819Z ...............................................................i.................................... 2800/9468
2020-01-02T09:18:51.9042127Z .................................................................................................... 2900/9468
2020-01-02T09:18:59.8763724Z .....................................................................................i.............. 3000/9468
2020-01-02T09:19:06.0209219Z .................................................................................................... 3100/9468
2020-01-02T09:19:13.7213411Z .................................................................................................... 3200/9468
2020-01-02T09:19:19.0590399Z F....................................................................ii............................. 3300/9468
2020-01-02T09:19:34.8207900Z .................................................................................................... 3500/9468
2020-01-02T09:19:43.1379871Z ............................................................i....................................... 3600/9468
2020-01-02T09:19:48.5071665Z .......i............................................................................................ 3700/9468
2020-01-02T09:19:54.5718357Z .................................................................................................... 3800/9468
---
2020-01-02T09:21:10.2406346Z ..................i...............i................................................................. 4900/9468
2020-01-02T09:21:20.2346476Z .................................................................................................... 5000/9468
2020-01-02T09:21:25.8098650Z ...............................................................i.................................... 5100/9468
2020-01-02T09:21:34.0777037Z .................................................................................................... 5200/9468
2020-01-02T09:21:41.4628101Z ..............................ii.ii...........i..................................................... 5300/9468
2020-01-02T09:21:50.6973885Z .................................................................................................... 5500/9468
2020-01-02T09:22:00.6544084Z .................................................................................................... 5600/9468
2020-01-02T09:22:07.7504591Z .............i...................................................................................... 5700/9468
2020-01-02T09:22:13.8520173Z .................................................................................................... 5800/9468
2020-01-02T09:22:13.8520173Z .................................................................................................... 5800/9468
2020-01-02T09:22:24.4362654Z .................................................................................................... 5900/9468
2020-01-02T09:22:36.3316233Z .ii...i..ii...........i............................................................................. 6000/9468
2020-01-02T09:22:54.2161450Z .................................................................................................... 6200/9468
2020-01-02T09:23:01.6902290Z .................................................................................................... 6300/9468
2020-01-02T09:23:01.6902290Z .................................................................................................... 6300/9468
2020-01-02T09:23:15.4060402Z ............................i..ii................................................................... 6400/9468
2020-01-02T09:23:35.5411452Z .................................................................................................... 6600/9468
2020-01-02T09:23:37.6904841Z ...i................................................................................................ 6700/9468
2020-01-02T09:23:40.1659651Z .................................................................................................... 6800/9468
2020-01-02T09:23:42.7330622Z ...i................................................................................................ 6900/9468
---
2020-01-02T09:25:19.9634704Z .................................................................................................... 7500/9468
2020-01-02T09:25:24.7610036Z .................................................................................................... 7600/9468
2020-01-02T09:25:29.9897405Z .................................................................................................... 7700/9468
2020-01-02T09:25:40.1868524Z .................................................................................................... 7800/9468
2020-01-02T09:25:47.7081745Z .....................................iiii........................................................... 7900/9468
2020-01-02T09:26:02.3372221Z .................................................................................................... 8100/9468
2020-01-02T09:26:11.0039331Z .................................................................................................... 8200/9468
2020-01-02T09:26:25.0802911Z .................................................................................................... 8300/9468
2020-01-02T09:26:33.1723016Z .................................................................................................... 8400/9468
---
2020-01-02T09:28:27.1246501Z error: /checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs:10: unexpected error: '10:9: 10:30: `$crate` may not be imported'
2020-01-02T09:28:27.1246666Z 
2020-01-02T09:28:27.1246839Z error: 2 unexpected errors found, 0 expected errors not found
2020-01-02T09:28:27.1246989Z status: exit code: 1
2020-01-02T09:28:27.1248050Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dollar-crate/dollar-crate-is-keyword" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dollar-crate/dollar-crate-is-keyword/auxiliary" "-A" "unused"
2020-01-02T09:28:27.1248516Z     Error {
2020-01-02T09:28:27.1248669Z         line_num: 9,
2020-01-02T09:28:27.1248809Z         kind: Some(
2020-01-02T09:28:27.1248970Z             Error,
---
2020-01-02T09:28:27.1252284Z ---- [ui] ui/imports/import-crate-var.rs stdout ----
2020-01-02T09:28:27.1252449Z 
2020-01-02T09:28:27.1252843Z error: test compilation failed although it shouldn't!
2020-01-02T09:28:27.1253022Z status: exit code: 1
2020-01-02T09:28:27.1254061Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/imports/import-crate-var.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/import-crate-var" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/import-crate-var/auxiliary" "-A" "unused"
2020-01-02T09:28:27.1255350Z ------------------------------------------
2020-01-02T09:28:27.1255389Z 
2020-01-02T09:28:27.1255611Z ------------------------------------------
2020-01-02T09:28:27.1255680Z stderr:
---
2020-01-02T09:28:27.1258670Z 
2020-01-02T09:28:27.1263035Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:385:22
2020-01-02T09:28:27.1274543Z 
2020-01-02T09:28:27.1274615Z 
2020-01-02T09:28:27.1280481Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-01-02T09:28:27.1280787Z 
2020-01-02T09:28:27.1280820Z 
2020-01-02T09:28:27.1286542Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-01-02T09:28:27.1286616Z Build completed unsuccessfully in 1:04:52
2020-01-02T09:28:27.1286616Z Build completed unsuccessfully in 1:04:52
2020-01-02T09:28:27.1347885Z == clock drift check ==
2020-01-02T09:28:27.8587781Z   local time: Thu Jan  2 09:28:27 UTC 2020
2020-01-02T09:28:27.8588423Z   network time: Thu, 02 Jan 2020 09:28:27 GMT
2020-01-02T09:28:27.8588757Z == end clock drift check ==
2020-01-02T09:28:28.7312419Z 
2020-01-02T09:28:28.7414633Z ##[error]Bash exited with code '1'.
2020-01-02T09:28:28.7482284Z ##[section]Starting: Checkout
2020-01-02T09:28:28.7484063Z ==============================================================================
2020-01-02T09:28:28.7484120Z Task         : Get sources
2020-01-02T09:28:28.7484168Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-02T10:09:11.5525791Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-02T10:09:11.5744164Z ##[command]git config gc.auto 0
2020-01-02T10:09:11.5815382Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-02T10:09:11.5885812Z ##[command]git config --get-all http.proxy
2020-01-02T10:09:11.6035132Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67775/merge:refs/remotes/pull/67775/merge
---
2020-01-02T11:05:42.8070673Z .................................................................................................... 1500/9468
2020-01-02T11:05:48.8385121Z .................................................................................................... 1600/9468
2020-01-02T11:05:53.9658174Z .................................................................................................... 1700/9468
2020-01-02T11:06:03.5449822Z .................................................................................................... 1800/9468
2020-01-02T11:06:11.9270890Z .i.................................................................................................. 1900/9468
2020-01-02T11:06:18.7602762Z ........................................................................................iiiii....... 2000/9468
2020-01-02T11:06:41.2720571Z .................................................................................................... 2200/9468
2020-01-02T11:06:43.7100524Z .................................................................................................... 2300/9468
2020-01-02T11:06:46.2506596Z .................................................................................................... 2400/9468
2020-01-02T11:06:52.6627991Z .................................................................................................... 2500/9468
2020-01-02T11:06:52.6627991Z .................................................................................................... 2500/9468
2020-01-02T11:07:13.4997002Z .................................................................................................... 2600/9468
2020-01-02T11:07:16.5058622Z .................................................................................................... 2700/9468
2020-01-02T11:07:27.5829317Z ...............................................................i.................................... 2800/9468
2020-01-02T11:07:33.8049693Z .................................................................................................... 2900/9468
2020-01-02T11:07:42.0303016Z .....................................................................................i.............. 3000/9468
2020-01-02T11:07:48.4016273Z .................................................................................................... 3100/9468
2020-01-02T11:07:56.4632570Z .................................................................................................... 3200/9468
2020-01-02T11:08:02.0711280Z F....................................................................ii............................. 3300/9468
2020-01-02T11:08:18.5606707Z .................................................................................................... 3500/9468
2020-01-02T11:08:27.3540378Z ............................................................i....................................... 3600/9468
2020-01-02T11:08:32.8991386Z .......i............................................................................................ 3700/9468
2020-01-02T11:08:39.2719394Z .................................................................................................... 3800/9468
---
2020-01-02T11:09:58.1280783Z ..................i...............i................................................................. 4900/9468
2020-01-02T11:10:08.2869976Z .................................................................................................... 5000/9468
2020-01-02T11:10:14.2862958Z ...............................................................i.................................... 5100/9468
2020-01-02T11:10:22.7419876Z .................................................................................................... 5200/9468
2020-01-02T11:10:30.5558259Z ..............................ii.ii...........i..................................................... 5300/9468
2020-01-02T11:10:40.3735598Z .................................................................................................... 5500/9468
2020-01-02T11:10:51.0369599Z .................................................................................................... 5600/9468
2020-01-02T11:10:58.3466804Z .............i...................................................................................... 5700/9468
2020-01-02T11:11:04.6829818Z .................................................................................................... 5800/9468
2020-01-02T11:11:04.6829818Z .................................................................................................... 5800/9468
2020-01-02T11:11:15.9318836Z .................................................................................................... 5900/9468
2020-01-02T11:11:28.2797490Z .ii...i..ii...........i............................................................................. 6000/9468
2020-01-02T11:11:46.6070769Z .................................................................................................... 6200/9468
2020-01-02T11:11:53.9924911Z .................................................................................................... 6300/9468
2020-01-02T11:11:53.9924911Z .................................................................................................... 6300/9468
2020-01-02T11:12:12.6489850Z ............................i..ii................................................................... 6400/9468
2020-01-02T11:12:33.5902459Z .................................................................................................... 6600/9468
2020-01-02T11:12:35.8541892Z ...i................................................................................................ 6700/9468
2020-01-02T11:12:38.3123810Z .................................................................................................... 6800/9468
2020-01-02T11:12:40.8942894Z ...i................................................................................................ 6900/9468
---
2020-01-02T11:14:22.1334515Z .................................................................................................... 7500/9468
2020-01-02T11:14:27.1588463Z .................................................................................................... 7600/9468
2020-01-02T11:14:32.6992503Z .................................................................................................... 7700/9468
2020-01-02T11:14:43.1484832Z .................................................................................................... 7800/9468
2020-01-02T11:14:51.0437717Z .....................................iiii........................................................... 7900/9468
2020-01-02T11:15:06.1058331Z .................................................................................................... 8100/9468
2020-01-02T11:15:14.4829465Z .................................................................................................... 8200/9468
2020-01-02T11:15:28.2179076Z .................................................................................................... 8300/9468
2020-01-02T11:15:35.9473398Z .................................................................................................... 8400/9468
---
2020-01-02T11:17:32.6748690Z 
2020-01-02T11:17:32.6748841Z 19 error: `$crate` may not be imported
2020-01-02T11:17:32.6749416Z 20   --> $DIR/dollar-crate-is-keyword.rs:9:9
2020-01-02T11:17:32.6749771Z 21    |
2020-01-02T11:17:32.6750150Z - LL |         use $crate; // ERROR `$crate` may not be imported
2020-01-02T11:17:32.6750321Z + LL |         use $crate;
2020-01-02T11:17:32.6750613Z 24 ...
2020-01-02T11:17:32.6750613Z 24 ...
2020-01-02T11:17:32.6750744Z 25 LL | m!();
2020-01-02T11:17:32.6751127Z 
2020-01-02T11:17:32.6751279Z The actual stderr differed from the expected stderr.
2020-01-02T11:17:32.6751712Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dollar-crate/dollar-crate-is-keyword/dollar-crate-is-keyword.stderr
2020-01-02T11:17:32.6751712Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dollar-crate/dollar-crate-is-keyword/dollar-crate-is-keyword.stderr
2020-01-02T11:17:32.6752119Z To update references, rerun the tests and pass the `--bless` flag
2020-01-02T11:17:32.6752767Z To only update this specific test, also pass `--test-args dollar-crate/dollar-crate-is-keyword.rs`
2020-01-02T11:17:32.6753080Z error: 1 errors occurred comparing output.
2020-01-02T11:17:32.6753222Z status: exit code: 1
2020-01-02T11:17:32.6753222Z status: exit code: 1
2020-01-02T11:17:32.6754752Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dollar-crate/dollar-crate-is-keyword" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dollar-crate/dollar-crate-is-keyword/auxiliary" "-A" "unused"
2020-01-02T11:17:32.6755471Z ------------------------------------------
2020-01-02T11:17:32.6755675Z 
2020-01-02T11:17:32.6756029Z ------------------------------------------
2020-01-02T11:17:32.6756681Z stderr:
2020-01-02T11:17:32.6756681Z stderr:
2020-01-02T11:17:32.6757647Z ------------------------------------------
2020-01-02T11:17:32.6757905Z error: expected identifier, found reserved identifier `$crate`
2020-01-02T11:17:32.6759000Z   --> /checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs:6:20
2020-01-02T11:17:32.6759253Z    |
2020-01-02T11:17:32.6759571Z LL |             struct $crate {} //~ ERROR expected identifier, found reserved identifier `$crate`
2020-01-02T11:17:32.6760150Z ...
2020-01-02T11:17:32.6760150Z ...
2020-01-02T11:17:32.6760467Z LL | m!();
2020-01-02T11:17:32.6761052Z 
2020-01-02T11:17:32.6761204Z error: expected identifier, found reserved identifier `$crate`
2020-01-02T11:17:32.6761638Z   --> /checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs:10:23
2020-01-02T11:17:32.6761833Z    |
2020-01-02T11:17:32.6761833Z    |
2020-01-02T11:17:32.6762018Z LL |         use $crate as $crate; //~ ERROR expected identifier, found reserved identifier `$crate`
2020-01-02T11:17:32.6762346Z ...
2020-01-02T11:17:32.6762346Z ...
2020-01-02T11:17:32.6762488Z LL | m!();
2020-01-02T11:17:32.6763026Z 
2020-01-02T11:17:32.6763231Z error: `$crate` may not be imported
2020-01-02T11:17:32.6763821Z   --> /checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs:9:9
2020-01-02T11:17:32.6764035Z    |
2020-01-02T11:17:32.6764035Z    |
2020-01-02T11:17:32.6764188Z LL |         use $crate; //~ ERROR `$crate` may not be imported
2020-01-02T11:17:32.6764496Z ...
2020-01-02T11:17:32.6764496Z ...
2020-01-02T11:17:32.6764634Z LL | m!();
2020-01-02T11:17:32.6765186Z 
2020-01-02T11:17:32.6765634Z error: `$crate` may not be imported
2020-01-02T11:17:32.6766102Z   --> /checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs:10:9
2020-01-02T11:17:32.6766290Z    |
2020-01-02T11:17:32.6766290Z    |
2020-01-02T11:17:32.6766649Z LL |         use $crate as $crate; //~ ERROR expected identifier, found reserved identifier `$crate`
2020-01-02T11:17:32.6768644Z ...
2020-01-02T11:17:32.6768644Z ...
2020-01-02T11:17:32.6768856Z LL | m!();
2020-01-02T11:17:32.6770405Z 
2020-01-02T11:17:32.6771917Z error: aborting due to 4 previous errors
2020-01-02T11:17:32.6772169Z 
2020-01-02T11:17:32.6772407Z 
---
2020-01-02T11:17:32.6786980Z 9 
2020-01-02T11:17:32.6787114Z 
2020-01-02T11:17:32.6787243Z 
2020-01-02T11:17:32.6787396Z The actual stderr differed from the expected stderr.
2020-01-02T11:17:32.6787923Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/import-crate-var/import-crate-var.stderr
2020-01-02T11:17:32.6788579Z To update references, rerun the tests and pass the `--bless` flag
2020-01-02T11:17:32.6788978Z To only update this specific test, also pass `--test-args imports/import-crate-var.rs`
2020-01-02T11:17:32.6789288Z error: 1 errors occurred comparing output.
2020-01-02T11:17:32.6789439Z status: exit code: 1
2020-01-02T11:17:32.6789439Z status: exit code: 1
2020-01-02T11:17:32.6790469Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/imports/import-crate-var.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/import-crate-var" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/import-crate-var/auxiliary" "-A" "unused"
2020-01-02T11:17:32.6791060Z ------------------------------------------
2020-01-02T11:17:32.6791223Z 
2020-01-02T11:17:32.6791547Z ------------------------------------------
2020-01-02T11:17:32.6791702Z stderr:
---
2020-01-02T11:17:32.6802428Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:385:22
2020-01-02T11:17:32.6802523Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2020-01-02T11:17:32.6802553Z 
2020-01-02T11:17:32.6802576Z 
2020-01-02T11:17:32.6805736Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-01-02T11:17:32.6806031Z 
2020-01-02T11:17:32.6806064Z 
2020-01-02T11:17:32.6825715Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-01-02T11:17:32.6828388Z Build completed unsuccessfully in 1:02:09
2020-01-02T11:17:32.6828388Z Build completed unsuccessfully in 1:02:09
2020-01-02T11:17:32.6883510Z == clock drift check ==
2020-01-02T11:17:32.6913992Z   local time: Thu Jan  2 11:17:32 UTC 2020
2020-01-02T11:17:32.9758162Z   network time: Thu, 02 Jan 2020 11:17:32 GMT
2020-01-02T11:17:32.9762044Z == end clock drift check ==
2020-01-02T11:17:33.9799443Z 
2020-01-02T11:17:33.9935858Z ##[error]Bash exited with code '1'.
2020-01-02T11:17:33.9972729Z ##[section]Starting: Checkout
2020-01-02T11:17:33.9975468Z ==============================================================================
2020-01-02T11:17:33.9975528Z Task         : Get sources
2020-01-02T11:17:33.9975596Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-03T09:51:18.3339187Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-03T09:51:18.3512238Z ##[command]git config gc.auto 0
2020-01-03T09:51:19.0506001Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-03T09:51:19.0512345Z ##[command]git config --get-all http.proxy
2020-01-03T09:51:19.0519617Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67775/merge:refs/remotes/pull/67775/merge
---
2020-01-03T10:51:13.9027522Z .................................................................................................... 1500/9467
2020-01-03T10:51:19.6942247Z .................................................................................................... 1600/9467
2020-01-03T10:51:24.5811597Z .................................................................................................... 1700/9467
2020-01-03T10:51:33.8855523Z .................................................................................................... 1800/9467
2020-01-03T10:51:42.0013805Z i................................................................................................... 1900/9467
2020-01-03T10:51:48.6312261Z ......................................................................................iiiii......... 2000/9467
2020-01-03T10:52:10.1262315Z .................................................................................................... 2200/9467
2020-01-03T10:52:12.4962765Z .................................................................................................... 2300/9467
2020-01-03T10:52:14.9484704Z .................................................................................................... 2400/9467
2020-01-03T10:52:21.0123691Z .................................................................................................... 2500/9467
---
2020-01-03T10:55:18.6554360Z .................i...............i.................................................................. 4900/9467
2020-01-03T10:55:28.5486369Z .................................................................................................... 5000/9467
2020-01-03T10:55:34.0908075Z ..............................................................i..................................... 5100/9467
2020-01-03T10:55:42.2244627Z .................................................................................................... 5200/9467
2020-01-03T10:55:49.7397286Z .............................ii.ii...........i...................................................... 5300/9467
2020-01-03T10:55:58.9180860Z .................................................................................................... 5500/9467
2020-01-03T10:56:08.9162101Z .................................................................................................... 5600/9467
2020-01-03T10:56:15.9793410Z ............i....................................................................................... 5700/9467
2020-01-03T10:56:22.1320847Z .................................................................................................... 5800/9467
2020-01-03T10:56:22.1320847Z .................................................................................................... 5800/9467
2020-01-03T10:56:32.8362454Z .................................................................................................... 5900/9467
2020-01-03T10:56:44.5909891Z ii...i..ii...........i.............................................................................. 6000/9467
2020-01-03T10:57:02.4741623Z .................................................................................................... 6200/9467
2020-01-03T10:57:09.7153398Z .................................................................................................... 6300/9467
2020-01-03T10:57:09.7153398Z .................................................................................................... 6300/9467
2020-01-03T10:57:23.3719916Z ...........................i..ii.................................................................... 6400/9467
2020-01-03T10:57:43.2735090Z .................................................................................................... 6600/9467
2020-01-03T10:57:45.3932220Z ..i................................................................................................. 6700/9467
2020-01-03T10:57:47.7329257Z .................................................................................................... 6800/9467
2020-01-03T10:57:50.3165124Z ..i................................................................................................. 6900/9467
---
2020-01-03T10:59:27.6937859Z .................................................................................................... 7500/9467
2020-01-03T10:59:32.6604849Z .................................................................................................... 7600/9467
2020-01-03T10:59:38.0778698Z .................................................................................................... 7700/9467
2020-01-03T10:59:48.2442499Z .................................................................................................... 7800/9467
2020-01-03T10:59:55.7638165Z ....................................iiii............................................................ 7900/9467
2020-01-03T11:00:10.6625921Z .................................................................................................... 8100/9467
2020-01-03T11:00:19.2965559Z .................................................................................................... 8200/9467
2020-01-03T11:00:33.3930313Z .................................................................................................... 8300/9467
2020-01-03T11:00:41.3735705Z .................................................................................................... 8400/9467
---
2020-01-03T11:02:36.1005204Z 38 
2020-01-03T11:02:36.1005309Z 
2020-01-03T11:02:36.1005417Z 
2020-01-03T11:02:36.1005544Z The actual stderr differed from the expected stderr.
2020-01-03T11:02:36.1006180Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dollar-crate/dollar-crate-is-keyword/dollar-crate-is-keyword.stderr
2020-01-03T11:02:36.1006561Z To update references, rerun the tests and pass the `--bless` flag
2020-01-03T11:02:36.1007034Z To only update this specific test, also pass `--test-args dollar-crate/dollar-crate-is-keyword.rs`
2020-01-03T11:02:36.1007342Z error: 1 errors occurred comparing output.
2020-01-03T11:02:36.1007499Z status: exit code: 1
2020-01-03T11:02:36.1007499Z status: exit code: 1
2020-01-03T11:02:36.1008520Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dollar-crate/dollar-crate-is-keyword" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dollar-crate/dollar-crate-is-keyword/auxiliary" "-A" "unused"
2020-01-03T11:02:36.1009128Z ------------------------------------------
2020-01-03T11:02:36.1009297Z 
2020-01-03T11:02:36.1009641Z ------------------------------------------
2020-01-03T11:02:36.1009810Z stderr:
2020-01-03T11:02:36.1009810Z stderr:
2020-01-03T11:02:36.1010164Z ------------------------------------------
2020-01-03T11:02:36.1010332Z error: expected identifier, found reserved identifier `$crate`
2020-01-03T11:02:36.1010697Z   --> /checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs:6:20
2020-01-03T11:02:36.1010888Z    |
2020-01-03T11:02:36.1011029Z LL |             struct $crate {} //~ ERROR expected identifier, found reserved identifier `$crate`
2020-01-03T11:02:36.1011797Z ...
2020-01-03T11:02:36.1011797Z ...
2020-01-03T11:02:36.1011942Z LL | m!();
2020-01-03T11:02:36.1012515Z 
2020-01-03T11:02:36.1012662Z error: expected identifier, found reserved identifier `$crate`
2020-01-03T11:02:36.1013067Z   --> /checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs:10:23
2020-01-03T11:02:36.1013241Z    |
2020-01-03T11:02:36.1013241Z    |
2020-01-03T11:02:36.1013402Z LL |         use $crate as $crate; //~ ERROR expected identifier, found reserved identifier `$crate`
2020-01-03T11:02:36.1013721Z ...
2020-01-03T11:02:36.1013721Z ...
2020-01-03T11:02:36.1013876Z LL | m!();
2020-01-03T11:02:36.1014366Z 
2020-01-03T11:02:36.1014508Z error: `$crate` may not be imported
2020-01-03T11:02:36.1015761Z   --> /checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs:9:9
2020-01-03T11:02:36.1018299Z    |
2020-01-03T11:02:36.1018299Z    |
2020-01-03T11:02:36.1018757Z LL |         use $crate; //~ ERROR `$crate` may not be imported
2020-01-03T11:02:36.1020215Z ...
2020-01-03T11:02:36.1020215Z ...
2020-01-03T11:02:36.1020280Z LL | m!();
2020-01-03T11:02:36.1020624Z 
2020-01-03T11:02:36.1020681Z error: `$crate` may not be imported
2020-01-03T11:02:36.1020904Z   --> /checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs:10:9
2020-01-03T11:02:36.1021078Z    |
2020-01-03T11:02:36.1021078Z    |
2020-01-03T11:02:36.1021133Z LL |         use $crate as $crate; //~ ERROR expected identifier, found reserved identifier `$crate`
2020-01-03T11:02:36.1021861Z ...
2020-01-03T11:02:36.1021861Z ...
2020-01-03T11:02:36.1021908Z LL | m!();
2020-01-03T11:02:36.1022239Z 
2020-01-03T11:02:36.1022283Z error: aborting due to 4 previous errors
2020-01-03T11:02:36.1022312Z 
2020-01-03T11:02:36.1022356Z 
---
2020-01-03T11:02:36.1023665Z 10 
2020-01-03T11:02:36.1023692Z 
2020-01-03T11:02:36.1023718Z 
2020-01-03T11:02:36.1023763Z The actual stderr differed from the expected stderr.
2020-01-03T11:02:36.1024090Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/import-crate-var/import-crate-var.stderr
2020-01-03T11:02:36.1024343Z To update references, rerun the tests and pass the `--bless` flag
2020-01-03T11:02:36.1024619Z To only update this specific test, also pass `--test-args imports/import-crate-var.rs`
2020-01-03T11:02:36.1024718Z error: 1 errors occurred comparing output.
2020-01-03T11:02:36.1024927Z status: exit code: 1
2020-01-03T11:02:36.1024927Z status: exit code: 1
2020-01-03T11:02:36.1025688Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/imports/import-crate-var.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/import-crate-var" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/import-crate-var/auxiliary" "-A" "unused"
2020-01-03T11:02:36.1025985Z ------------------------------------------
2020-01-03T11:02:36.1026021Z 
2020-01-03T11:02:36.1026210Z ------------------------------------------
2020-01-03T11:02:36.1026250Z stderr:
---
2020-01-03T11:02:36.1028838Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:385:22
2020-01-03T11:02:36.1028901Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2020-01-03T11:02:36.1038480Z 
2020-01-03T11:02:36.1038600Z 
2020-01-03T11:02:36.1040334Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-01-03T11:02:36.1040761Z 
2020-01-03T11:02:36.1040789Z 
2020-01-03T11:02:36.1045191Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-01-03T11:02:36.1045256Z Build completed unsuccessfully in 1:04:58
2020-01-03T11:02:36.1045256Z Build completed unsuccessfully in 1:04:58
2020-01-03T11:02:36.1104259Z == clock drift check ==
2020-01-03T11:02:36.1123104Z   local time: Fri Jan  3 11:02:36 UTC 2020
2020-01-03T11:02:36.2092164Z   network time: Fri, 03 Jan 2020 11:02:36 GMT
2020-01-03T11:02:36.2094773Z == end clock drift check ==
2020-01-03T11:02:37.5148785Z 
2020-01-03T11:02:37.5229552Z ##[error]Bash exited with code '1'.
2020-01-03T11:02:37.5275942Z ##[section]Starting: Checkout
2020-01-03T11:02:37.5277586Z ==============================================================================
2020-01-03T11:02:37.5277637Z Task         : Get sources
2020-01-03T11:02:37.5277681Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Co-Authored-By: Yuki Okushi <huyuumi.dev@gmail.com>
@mental32
Copy link
Contributor Author

mental32 commented Jan 3, 2020

@JohnTitor Thanks!

First time contributor here and the UI tests are difficult to get used to, I'm unable to build Rustc so I cant test changes locally, so far its been hit and miss :(

@JohnTitor
Copy link
Member

Uhm, applying suggestions on GitHub ignores blank lines, so could you insert them on your local and push it? Anyway, thanks for considering the contributions.

@JohnTitor
Copy link
Member

Also, it's good to squash commits into one.

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-03T15:48:53.8867128Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-03T15:48:54.8412828Z ##[command]git config gc.auto 0
2020-01-03T15:48:54.8418781Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-03T15:48:54.8423664Z ##[command]git config --get-all http.proxy
2020-01-03T15:48:54.8428294Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67775/merge:refs/remotes/pull/67775/merge
---
2020-01-03T16:45:46.0263060Z .................................................................................................... 1500/9470
2020-01-03T16:45:52.5284705Z .................................................................................................... 1600/9470
2020-01-03T16:45:57.9643194Z .................................................................................................... 1700/9470
2020-01-03T16:46:08.1054059Z .................................................................................................... 1800/9470
2020-01-03T16:46:16.9343026Z i................................................................................................... 1900/9470
2020-01-03T16:46:24.2526329Z ......................................................................................iiiii......... 2000/9470
2020-01-03T16:46:47.4952324Z .................................................................................................... 2200/9470
2020-01-03T16:46:50.1336748Z .................................................................................................... 2300/9470
2020-01-03T16:46:52.8010403Z .................................................................................................... 2400/9470
2020-01-03T16:46:59.4522605Z .................................................................................................... 2500/9470
2020-01-03T16:46:59.4522605Z .................................................................................................... 2500/9470
2020-01-03T16:47:20.3251619Z .................................................................................................... 2600/9470
2020-01-03T16:47:23.5738229Z .................................................................................................... 2700/9470
2020-01-03T16:47:35.2170763Z ..............................................................i..................................... 2800/9470
2020-01-03T16:47:41.7752922Z .................................................................................................... 2900/9470
2020-01-03T16:47:50.2387991Z ....................................................................................i............... 3000/9470
2020-01-03T16:47:57.0936295Z .................................................................................................... 3100/9470
2020-01-03T16:48:05.4948174Z .................................................................................................... 3200/9470
2020-01-03T16:48:11.2431553Z F....................................................................ii............................. 3300/9470
2020-01-03T16:48:28.6442880Z .................................................................................................... 3500/9470
2020-01-03T16:48:37.7038253Z ............................................................i....................................... 3600/9470
2020-01-03T16:48:43.5662910Z .......i............................................................................................ 3700/9470
2020-01-03T16:48:50.2040131Z .................................................................................................... 3800/9470
---
2020-01-03T16:50:12.6237160Z ..................i...............i................................................................. 4900/9470
2020-01-03T16:50:23.5036566Z .................................................................................................... 5000/9470
2020-01-03T16:50:29.7196948Z ...............................................................i.................................... 5100/9470
2020-01-03T16:50:38.5529760Z .................................................................................................... 5200/9470
2020-01-03T16:50:46.6546970Z ..............................ii.ii...........i..................................................... 5300/9470
2020-01-03T16:50:56.8750898Z .................................................................................................... 5500/9470
2020-01-03T16:51:07.7949701Z .................................................................................................... 5600/9470
2020-01-03T16:51:15.4245255Z .............i...................................................................................... 5700/9470
2020-01-03T16:51:22.1694690Z .................................................................................................... 5800/9470
2020-01-03T16:51:22.1694690Z .................................................................................................... 5800/9470
2020-01-03T16:51:33.7147378Z .................................................................................................... 5900/9470
2020-01-03T16:51:46.3054493Z ..ii...i..ii...........i............................................................................ 6000/9470
2020-01-03T16:52:04.7013548Z .................................................................................................... 6200/9470
2020-01-03T16:52:13.1144302Z .................................................................................................... 6300/9470
2020-01-03T16:52:13.1144302Z .................................................................................................... 6300/9470
2020-01-03T16:52:34.7036369Z .............................i..ii.................................................................. 6400/9470
2020-01-03T16:52:57.2881675Z .................................................................................................... 6600/9470
2020-01-03T16:52:59.6510697Z ....i............................................................................................... 6700/9470
2020-01-03T16:53:02.1945922Z .................................................................................................... 6800/9470
2020-01-03T16:53:05.0715878Z ....i............................................................................................... 6900/9470
---
2020-01-03T16:54:48.5250220Z .................................................................................................... 7500/9470
2020-01-03T16:54:53.7502643Z .................................................................................................... 7600/9470
2020-01-03T16:54:59.0406101Z .................................................................................................... 7700/9470
2020-01-03T16:55:10.5395261Z .................................................................................................... 7800/9470
2020-01-03T16:55:18.8550576Z .......................................iiii......................................................... 7900/9470
2020-01-03T16:55:34.8841634Z .................................................................................................... 8100/9470
2020-01-03T16:55:43.9827039Z .................................................................................................... 8200/9470
2020-01-03T16:55:58.9893905Z .................................................................................................... 8300/9470
2020-01-03T16:56:07.7392936Z .................................................................................................... 8400/9470
---
2020-01-03T16:58:14.3251309Z 38 
2020-01-03T16:58:14.3251504Z 
2020-01-03T16:58:14.3251722Z 
2020-01-03T16:58:14.3251943Z The actual stderr differed from the expected stderr.
2020-01-03T16:58:14.3252529Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dollar-crate/dollar-crate-is-keyword/dollar-crate-is-keyword.stderr
2020-01-03T16:58:14.3253139Z To update references, rerun the tests and pass the `--bless` flag
2020-01-03T16:58:14.3254055Z To only update this specific test, also pass `--test-args dollar-crate/dollar-crate-is-keyword.rs`
2020-01-03T16:58:14.3254719Z error: 1 errors occurred comparing output.
2020-01-03T16:58:14.3254956Z status: exit code: 1
2020-01-03T16:58:14.3254956Z status: exit code: 1
2020-01-03T16:58:14.3256153Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dollar-crate/dollar-crate-is-keyword" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dollar-crate/dollar-crate-is-keyword/auxiliary" "-A" "unused"
2020-01-03T16:58:14.3257043Z ------------------------------------------
2020-01-03T16:58:14.3257319Z 
2020-01-03T16:58:14.3257795Z ------------------------------------------
2020-01-03T16:58:14.3258107Z stderr:
2020-01-03T16:58:14.3258107Z stderr:
2020-01-03T16:58:14.3260305Z ------------------------------------------
2020-01-03T16:58:14.3260602Z error: expected identifier, found reserved identifier `$crate`
2020-01-03T16:58:14.3260929Z   --> /checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs:6:20
2020-01-03T16:58:14.3260983Z    |
2020-01-03T16:58:14.3261053Z LL |             struct $crate {} //~ ERROR expected identifier, found reserved identifier `$crate`
2020-01-03T16:58:14.3261172Z ...
2020-01-03T16:58:14.3261172Z ...
2020-01-03T16:58:14.3261212Z LL | m!();
2020-01-03T16:58:14.3277252Z 
2020-01-03T16:58:14.3277327Z error: expected identifier, found reserved identifier `$crate`
2020-01-03T16:58:14.3277627Z   --> /checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs:10:23
2020-01-03T16:58:14.3277678Z    |
2020-01-03T16:58:14.3277678Z    |
2020-01-03T16:58:14.3277756Z LL |         use $crate as $crate; //~ ERROR expected identifier, found reserved identifier `$crate`
2020-01-03T16:58:14.3277858Z ...
2020-01-03T16:58:14.3277858Z ...
2020-01-03T16:58:14.3277915Z LL | m!();
2020-01-03T16:58:14.3278166Z 
2020-01-03T16:58:14.3278207Z error: `$crate` may not be imported
2020-01-03T16:58:14.3278468Z   --> /checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs:9:9
2020-01-03T16:58:14.3278518Z    |
2020-01-03T16:58:14.3278518Z    |
2020-01-03T16:58:14.3278564Z LL |         use $crate; //~ ERROR `$crate` may not be imported
2020-01-03T16:58:14.3278669Z ...
2020-01-03T16:58:14.3278669Z ...
2020-01-03T16:58:14.3278708Z LL | m!();
2020-01-03T16:58:14.3279157Z 
2020-01-03T16:58:14.3279202Z error: `$crate` may not be imported
2020-01-03T16:58:14.3279499Z   --> /checkout/src/test/ui/dollar-crate/dollar-crate-is-keyword.rs:10:9
2020-01-03T16:58:14.3279564Z    |
2020-01-03T16:58:14.3279564Z    |
2020-01-03T16:58:14.3279719Z LL |         use $crate as $crate; //~ ERROR expected identifier, found reserved identifier `$crate`
2020-01-03T16:58:14.3279819Z ...
2020-01-03T16:58:14.3279819Z ...
2020-01-03T16:58:14.3279876Z LL | m!();
2020-01-03T16:58:14.3280152Z 
2020-01-03T16:58:14.3280194Z error: aborting due to 4 previous errors
2020-01-03T16:58:14.3280241Z 
2020-01-03T16:58:14.3280266Z 
---
2020-01-03T16:58:14.3281419Z 10 
2020-01-03T16:58:14.3281447Z 
2020-01-03T16:58:14.3281474Z 
2020-01-03T16:58:14.3281537Z The actual stderr differed from the expected stderr.
2020-01-03T16:58:14.3281888Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/import-crate-var/import-crate-var.stderr
2020-01-03T16:58:14.3282160Z To update references, rerun the tests and pass the `--bless` flag
2020-01-03T16:58:14.3284939Z To only update this specific test, also pass `--test-args imports/import-crate-var.rs`
2020-01-03T16:58:14.3285053Z error: 1 errors occurred comparing output.
2020-01-03T16:58:14.3285098Z status: exit code: 1
2020-01-03T16:58:14.3285098Z status: exit code: 1
2020-01-03T16:58:14.3287555Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/imports/import-crate-var.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/import-crate-var" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/import-crate-var/auxiliary" "-A" "unused"
2020-01-03T16:58:14.3288309Z ------------------------------------------
2020-01-03T16:58:14.3288362Z 
2020-01-03T16:58:14.3288591Z ------------------------------------------
2020-01-03T16:58:14.3288663Z stderr:
---
2020-01-03T16:58:14.3299561Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:385:22
2020-01-03T16:58:14.3299781Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2020-01-03T16:58:14.3299852Z 
2020-01-03T16:58:14.3299877Z 
2020-01-03T16:58:14.3301569Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-01-03T16:58:14.3302127Z 
2020-01-03T16:58:14.3302158Z 
2020-01-03T16:58:14.3310381Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-01-03T16:58:14.3310474Z Build completed unsuccessfully in 1:02:45
2020-01-03T16:58:14.3310474Z Build completed unsuccessfully in 1:02:45
2020-01-03T16:58:14.3372949Z == clock drift check ==
2020-01-03T16:58:14.3390267Z   local time: Fri Jan  3 16:58:14 UTC 2020
2020-01-03T16:58:14.8947521Z   network time: Fri, 03 Jan 2020 16:58:14 GMT
2020-01-03T16:58:14.8949317Z == end clock drift check ==
2020-01-03T16:58:15.8212402Z 
2020-01-03T16:58:15.8313972Z ##[error]Bash exited with code '1'.
2020-01-03T16:58:15.8384331Z ##[section]Starting: Checkout
2020-01-03T16:58:15.8386201Z ==============================================================================
2020-01-03T16:58:15.8386257Z Task         : Get sources
2020-01-03T16:58:15.8386306Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Dylan-DPC-zz
Copy link

yaay finally :P

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 4, 2020

📌 Commit c818f4c has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 4, 2020
bors added a commit that referenced this pull request Jan 4, 2020
Rollup of 4 pull requests

Successful merges:

 - #67137 (libstd uses `core::panic::Location` where possible.)
 - #67709 (Introduce an option for disabling deduplication of diagnostics)
 - #67775 (Make "use $crate" a hard error)
 - #67812 (Tweak and extend internal BTreeMap documentation, including debug asserts.)

Failed merges:

r? @ghost
@bors bors merged commit c818f4c into rust-lang:master Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue for use $crate; compatibility warning
6 participants