Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove 32-bit Apple targets #67732

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Conversation

pietroalbini
Copy link
Member

This PR drops the i686-apple and dist-i686-apple CI builders, as well as removing the armv7-apple-ios, armv7s-apple-ios and i386-apple-ios targets from the x86_64-apple CI builder.

The change was approved in RFC 2837, and it should land in Rust 1.42 stable (so this cycle).

r? @alexcrichton

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 30, 2019
@pietroalbini
Copy link
Member Author

Do not merge this until the blog post announcing the change is up.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jan 6, 2020

📌 Commit 67cc068 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2020
@bors
Copy link
Contributor

bors commented Jan 7, 2020

⌛ Testing commit 67cc068 with merge 56446fe...

bors added a commit that referenced this pull request Jan 7, 2020
ci: remove 32-bit Apple targets

This PR drops the `i686-apple` and `dist-i686-apple` CI builders, as well as removing the `armv7-apple-ios`, `armv7s-apple-ios`  and `i386-apple-ios` targets from the `x86_64-apple` CI builder.

The change was approved in [RFC 2837](rust-lang/rfcs#2837), and it should land in Rust 1.42 stable (so this cycle).

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Jan 7, 2020

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing 56446fe to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 7, 2020
@bors bors merged commit 67cc068 into rust-lang:master Jan 7, 2020
@pietroalbini pietroalbini deleted the fewer-apples branch December 23, 2020 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants