Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #67449

Merged
merged 21 commits into from
Dec 20, 2019
Merged

Rollup of 7 pull requests #67449

merged 21 commits into from
Dec 20, 2019

Commits on Dec 12, 2019

  1. Configuration menu
    Copy the full SHA
    3980342 View commit details
    Browse the repository at this point in the history
  2. review comments

    estebank committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    8c4f1d5 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2019

  1. Configuration menu
    Copy the full SHA
    8a4632d View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2019

  1. Remove now-redundant range check on u128 -> f32 casts

    This code was added to avoid UB in LLVM 6 and earlier, but we no longer support those LLVM versions.
    Since https://reviews.llvm.org/D47807 (released in LLVM 7), uitofp does exactly what we need.
    
    Closes rust-lang#51872
    Robin Kruppe committed Dec 15, 2019
    Configuration menu
    Copy the full SHA
    6ad0b55 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2019

  1. Fix up Command Debug output when arg0 is specified.

    PR rust-lang#66512 added the ability to set argv[0] on
    Command. As a side effect, it changed the Debug output to print both the program and
    argv[0], which in practice results in stuttery output ("echo echo foo").
    
    This PR reverts the behaviour to the the old one, so that the command is only printed
    once - unless arg0 has been set. In that case it emits "[command] arg0 arg1 ...".
    jsgf committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    232022f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ce56e75 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2019

  1. Configuration menu
    Copy the full SHA
    17aa0cb View commit details
    Browse the repository at this point in the history
  2. remove a bit more hackery

    mark-i-m committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    3ec3fca View commit details
    Browse the repository at this point in the history
  3. use usize::MAX instead of !0

    mark-i-m committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    baaf864 View commit details
    Browse the repository at this point in the history
  4. fix import

    mark-i-m committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    951f041 View commit details
    Browse the repository at this point in the history
  5. add fixme

    mark-i-m committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    2535435 View commit details
    Browse the repository at this point in the history
  6. no need to bootstrap

    mark-i-m committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    7d26811 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2019

  1. Configuration menu
    Copy the full SHA
    b826711 View commit details
    Browse the repository at this point in the history
  2. Move command line option definitions into a dedicated file

    config.rs has reached the 3000 line tidy limit, this commit moves
    command line option definitions into a new file - options.rs,  and
    leaves the rest of configuration infrastructure in config.rs.
    Victor Ding committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    83fc600 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#66755 - mark-i-m:const-vec-new, r=ecstatic-…

    …morse
    
    Remove a const-if-hack in RawVec
    
    r? @ecstatic-morse
    
    cc @Centril
    Centril committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    57da9d3 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#67127 - estebank:disambiguate-suggestion, r…

    …=varkor
    
    Use structured suggestion for disambiguating method calls
    
    Fix rust-lang#65635.
    Centril committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    f0eb4b4 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#67219 - jsgf:command-argv0-debug, r=joshtri…

    …plett
    
    Fix up Command Debug output when arg0 is specified.
    
    PR rust-lang#66512 added the ability to set argv[0] on
    Command. As a side effect, it changed the Debug output to print both the program and
    argv[0], which in practice results in stuttery output (`"echo" "echo" "foo"`).
    
    This PR reverts the behaviour to the the old one, so that the command is only printed
    once - unless arg0 has been set. In that case it emits `"[command]" "arg0" "arg1" ...`.
    Centril committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    b779cbb View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#67285 - ohadravid:indicate-origin-of-where-…

    …type-parameter, r=estebank
    
    Indicate origin of where type parameter for uninferred types
    
    Based on rust-lang#65951 (which is not merge yet), fixes rust-lang#67277.
    
    This PR improves a little the diagnostic for code like:
    
    ```
     async fn foo() {
         bar().await;
    }
    
     async fn bar<T>() -> () {}
    ```
    
    by showing:
    ```
    error[E0698]: type inside `async fn` body must be known in this context
     --> unresolved_type_param.rs:9:5
      |
    9 |     bar().await;
      |     ^^^ cannot infer type for type parameter `T` declared on the function `bar`
      |
    ...
    ```
    (The
    ```
    declared on the function `bar`
    ```
    part is new)
    
    A small side note: `Vec` and `slice` seem to resist this change, because querying `item_name()` panics, and `get_opt_name()` returns `None`.
    
    r? @estebank
    Centril committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    403bb09 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#67328 - rkruppe:simplify-u128-f32-cast, r=m…

    …atthewjasper
    
    Remove now-redundant range check on u128 -> f32 casts
    
    This code was added to avoid UB in LLVM 6 and earlier, but we no longer support those LLVM versions.
    Since https://reviews.llvm.org/D47807 (released in LLVM 7), uitofp does exactly what we need.
    
    Closes rust-lang#51872
    Centril committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    efd31c2 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#67367 - 0dvictor:options, r=Centril

    Move command line option definitions into a dedicated file
    
    config.rs has reached the 3000 line tidy limit, this commit moves command line option definitions into a new file - options.rs,  and leaves the rest of configuration infrastructure in config.rs.
    Centril committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    9f39cb1 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#67442 - reitermarkus:dummy-variable, r=kennytm

    Remove `SOCK_CLOEXEC` dummy variable on platforms that don't use it.
    Centril committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    3a336c4 View commit details
    Browse the repository at this point in the history