Cleanup err codes #67422
Merged
Cleanup err codes #67422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
| @@ -1,10 +1,24 @@ | |||
| In order to be consistent with Rust's lack of global type inference, | |||
| type and const placeholders are disallowed by design in item signatures. | |||
| The type placeholder `_` was used withing a type on an item's signature. | |||
There was a problem hiding this comment.
I think you made a typo here. Did you mean this?
Suggested change
| The type placeholder `_` was used withing a type on an item's signature. | |
| The type placeholder `_` was used within a type on an item's signature. |
Dylan-DPC-zz
previously approved these changes
Dec 19, 2019
| @@ -1,5 +1,7 @@ | |||
| An attempt was made to implement Drop on a trait, which is not allowed: only | |||
| structs and enums can implement Drop. An example causing this error: | |||
| The Drop was implemented on a trait, which is not allowed: only structs and | |||
There was a problem hiding this comment.
Suggested change
| The Drop was implemented on a trait, which is not allowed: only structs and | |
| The Drop trait was implemented on a trait, which is not allowed: only structs and |
|
@bors r+ rollup |
|
📌 Commit dce0f06 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 21, 2019
…=Dylan-DPC Cleanup err codes r? @Dylan-DPC
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 21, 2019
…=Dylan-DPC Cleanup err codes r? @Dylan-DPC
bors
added a commit
that referenced
this pull request
Dec 21, 2019
Rollup of 7 pull requests Successful merges: - #67059 (Fix too restrictive checks on Drop impls) - #67355 (Merge `ast::Mutability` and `mir::Mutability`) - #67393 (Enable opting out of specific default LLVM arguments.) - #67422 (Cleanup err codes) - #67462 (Make ptr::slice_from_raw_parts a const fn available under a feature flag) - #67467 (Test slice patterns more) - #67478 (Fix src/libcore/str/mod.rs doc comments) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Dylan-DPC