typeck: note other end-point when checking range pats #67287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
estebank
reviewed
Dec 13, 2019
| | ----------------------- this match expression has type `std::ops::Range<{integer}>` | ||
| LL | [..9, 99..100, _] => {}, | ||
| | -- ^^^ expected struct `std::ops::Range`, found integer | ||
| | | |
There was a problem hiding this comment.
I still don't understand what's happening here
There was a problem hiding this comment.
The first error above is for 99 and the other one is for 100. They now occur twice because the spans are different and so there's no de-duplication. The type error happens because 99..105 is at type Range<{integer}> whereas 99..100 is a range pattern at type {integer}.
There was a problem hiding this comment.
In my version I tried changing "this match expression has" to "this match expression requires" in an attempt to clarify these errors
There was a problem hiding this comment.
It's fine to change that, but that can be in a different PR than this (e.g. yours).
There was a problem hiding this comment.
The problem I have with this wording is "expected struct std::ops::Range, found integer", but now I see that the thing being matched is [5..4, 99..105, 43..44] and not [5, 99, 43], which accounts for the weirdness.
There was a problem hiding this comment.
Right, and that part hasn't changed as you can see from the diff. :)
This comment has been minimized.
This comment has been minimized.
Centril
force-pushed
the
mismatch-range-improve-diag
branch
from
bec6b77
to
196c27d
Compare
This comment has been minimized.
This comment has been minimized.
Centril
force-pushed
the
mismatch-range-improve-diag
branch
from
196c27d
to
01599fc
Compare
|
@bors r+ |
|
📌 Commit 01599fc has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 01599fc with merge 85fcf56a2c6d69af187ac70bf5007c7e074578ce... |
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Dec 26, 2019
…, r=estebank typeck: note other end-point when checking range pats Fixes rust-lang#57389, alternative to rust-lang#67214 that should be less invasive to type checking logic. r? @estebank
This comment has been minimized.
This comment has been minimized.
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Dec 26, 2019
…, r=estebank typeck: note other end-point when checking range pats Fixes rust-lang#57389, alternative to rust-lang#67214 that should be less invasive to type checking logic. r? @estebank
bors
added a commit
that referenced
this pull request
Dec 26, 2019
Rollup of 12 pull requests Successful merges: - #67112 (Refactor expression parsing thoroughly) - #67192 (Various const eval and pattern matching ICE fixes) - #67287 (typeck: note other end-point when checking range pats) - #67459 (prune ill-conceived BTreeMap iter_mut assertion and test its mutability) - #67576 (reuse `capacity` variable in slice::repeat) - #67602 (Use issue = "none" instead of "0" in intrinsics) - #67614 (Set callbacks globally) - #67617 (Remove `compiler_builtins_lib` documentation) - #67629 (Remove redundant link texts) - #67632 (Convert collapsed to shortcut reference links) - #67633 (Update .mailmap) - #67635 (Document safety of Path casting) Failed merges: r? @ghost
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-author
Centril
force-pushed
the
mismatch-range-improve-diag
branch
from
01599fc
to
c4b6de2
Compare
|
@bors r=estebank |
|
📌 Commit c4b6de2 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Dec 30, 2019
…, r=estebank typeck: note other end-point when checking range pats Fixes rust-lang#57389, alternative to rust-lang#67214 that should be less invasive to type checking logic. r? @estebank
bors
added a commit
that referenced
this pull request
Dec 30, 2019
Rollup of 10 pull requests Successful merges: - #64273 (Stabilize attribute macros on inline modules) - #67287 (typeck: note other end-point when checking range pats) - #67564 (docs: Iterator adapters have unspecified results after a panic) - #67622 (Some keyword documentation.) - #67657 (Clean up const-hack PRs now that const if / match exist.) - #67677 (resolve: Minor cleanup of duplicate macro reexports) - #67687 (Do not ICE on lifetime error involving closures) - #67698 (Move reachable_set and diagnostic_items to librustc_passes.) - #67701 (tidy: Enforce formatting rather than just check it if `--bless` is specified) - #67715 (Typo fix) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57389, alternative to #67214 that should be less invasive to type checking logic.
r? @estebank