Fix two OOM issues related to ConstProp
#66394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
wesleywiser
changed the title
ConstProp
wesleywiser
commented
Nov 14, 2019
Centril
reviewed
Nov 14, 2019
pnkfelix
added
the
beta-nominated
|
@bors r+ |
|
📌 Commit 0c52c3e has been approved by |
bors
added
S-waiting-on-bors
pnkfelix
added
the
T-compiler
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Nov 14, 2019
Fix two OOM issues related to `ConstProp` Fixes rust-lang#66342 Fixes rust-lang#66397 r? @oli-obk
|
@bors r- The two new test cases cause const evaluation error on 32-bit targets in #66417 (comment). |
bors
added
S-waiting-on-author
|
@bors r=oli-obk |
|
📌 Commit 3bd5226 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Nov 15, 2019
Fix two OOM issues related to `ConstProp` Fixes rust-lang#66342 Fixes rust-lang#66397 r? @oli-obk
bors
added a commit
that referenced
this pull request
Nov 15, 2019
Rollup of 12 pull requests Successful merges: - #65557 (rename Error::iter_chain() and remove Error::iter_sources()) - #66013 (Avoid hashing the key twice in `get_query()`.) - #66306 (Remove cannot mutate statics in initializer of another static error) - #66338 (Update mdbook.) - #66388 (Do not ICE on recovery from unmet associated type bound obligation) - #66390 (Fix ICE when trying to suggest `Type<>` instead of `Type()`) - #66391 (Do not ICE in `if` without `else` in `async fn`) - #66394 (Fix two OOM issues related to `ConstProp`) - #66398 (Remove some stack frames from `.async` calls) - #66410 (miri: helper methods for max values of machine's usize/isize) - #66418 (Link to tracking issue in HIR const-check error code description) - #66419 (Don't warn labels beginning with `_` on unused_labels lint) Failed merges: r? @ghost
|
Seems failed in #66436 (comment) |
bors
added
S-waiting-on-author
|
@bors r=oli-obk |
|
📌 Commit fd2595dbd29db8573c8a83c43ceda1b0002b235e has been approved by |
|
💔 Test failed - checks-azure |
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
@wesleywiser I noticed it's the wrong command. @bors r=oli-obk |
|
📌 Commit 2dea8af has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
|
beta-accepted (last week, sorry for delay!) |
pnkfelix
added
the
beta-accepted
Merged
Mark-Simulacrum
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Dec 7, 2019
[beta] backports This pull request backports the following pull requests, which have all been beta-accepted by the compiler team. * Handle non_exhaustive in borrow checking #66722 * Do not ICE on trait aliases with missing obligations #66392 * Do not ICE in `if` without `else` in `async fn` #66391 * Fix ICE when trying to suggest `Type<>` instead of `Type()` #66390 * Do not ICE on recovery from unmet associated type bound obligation #66388 * find_deprecation: deprecation attr may be ill-formed meta. #66381 * parser: don't use `unreachable!()` in `fn unexpected`. #66361 * Undo an assert causing an ICE until we fix the underlying problem #66250 * Do not ICE with a precision flag in formatting str and no format arguments #66093 * Fix two OOM issues related to `ConstProp` #66394
bors
added a commit
that referenced
this pull request
Dec 8, 2019
[beta] backports This pull request backports the following pull requests, which have all been beta-accepted by the compiler team. * Handle non_exhaustive in borrow checking #66722 * Do not ICE on trait aliases with missing obligations #66392 * Do not ICE in `if` without `else` in `async fn` #66391 * Fix ICE when trying to suggest `Type<>` instead of `Type()` #66390 * Do not ICE on recovery from unmet associated type bound obligation #66388 * find_deprecation: deprecation attr may be ill-formed meta. #66381 * parser: don't use `unreachable!()` in `fn unexpected`. #66361 * Undo an assert causing an ICE until we fix the underlying problem #66250 * Do not ICE with a precision flag in formatting str and no format arguments #66093 * Fix two OOM issues related to `ConstProp` #66394
dekellum
added a commit
to dekellum/hyperx
that referenced
this pull request
May 23, 2021
On windows-latest and rustc 1.39.0 we are seeing something related to what was fixed here: rust-lang/rust#66394
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66342
Fixes #66397
r? @oli-obk