Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #65087

Merged
merged 22 commits into from
Oct 4, 2019
Merged

Rollup of 5 pull requests #65087

merged 22 commits into from
Oct 4, 2019

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Oct 4, 2019

Successful merges:

Failed merges:

r? @ghost

csmoe and others added 22 commits September 29, 2019 16:17
This fixes some test differences and also avoids overflow in
issue-38591.rs.
It's entirely irrelevant to crate loading
It's a crate name after renaming, so it's entirely irrelevant to crate loading
It was only used for retreiving edition, which was a bug.
In case of dual proc macros the edition should be taken from the target crate version, like any other metadata.
It duplicates `CrateRoot::name`
…atsakis

Fix most remaining Polonius test differences

This fixes most of the Polonius test differences and also avoids overflow in issue-38591.rs.

r? @nikomatsakis
Replace ClosureSubsts with SubstsRef

Addresses rust-lang#42340 part 3
rust-lang#59312 might benefit from this clean up.
r? @nikomatsakis
Simplify ExprUseVisitor

* Remove HIR const qualification
* Remove parts of ExprUseVisitor that aren't being used

r? @eddyb
metadata: Some crate loading cleanup

So, my goal was to fix caching of loaded crates which is broken and causes ICEs like rust-lang#56935 or rust-lang#64450.
While investigating I found that the code is pretty messy and likes to confuse various things that look similar but are actually different.
This PR does some initial cleanup in that area, I hope to get to the caching itself a bit later.
…chenkov

Remove `borrowck_graphviz_postflow` from test

Resolves rust-lang#65071.

r? @petrochenkov
@Centril
Copy link
Contributor Author

Centril commented Oct 4, 2019

@bors r+ p=5 rollup=never

@bors
Copy link
Contributor

bors commented Oct 4, 2019

📌 Commit aacc89a has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 4, 2019
@bors
Copy link
Contributor

bors commented Oct 4, 2019

⌛ Testing commit aacc89a with merge 9e35a28...

bors added a commit that referenced this pull request Oct 4, 2019
Rollup of 5 pull requests

Successful merges:

 - #64749 (Fix most remaining Polonius test differences)
 - #64817 (Replace ClosureSubsts with SubstsRef)
 - #64874 (Simplify ExprUseVisitor)
 - #65026 (metadata: Some crate loading cleanup)
 - #65073 (Remove `borrowck_graphviz_postflow` from test)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Oct 4, 2019

☀️ Test successful - checks-azure
Approved by: Centril
Pushing 9e35a28 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 4, 2019
@bors bors merged commit aacc89a into rust-lang:master Oct 4, 2019
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #65087!

Tested on commit 9e35a28.
Direct link to PR: #65087

💔 clippy-driver on windows: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Oct 4, 2019
Tested on commit rust-lang/rust@9e35a28.
Direct link to PR: <rust-lang/rust#65087>

💔 clippy-driver on windows: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
@Centril Centril deleted the rollup-skxq0zr branch October 4, 2019 19:01
@Centril Centril added the rollup A PR which is a rollup label Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants