Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Add a shim for functions annotated with #[track_caller] (RFC 2091 #2/N) #65082

Closed
wants to merge 14 commits into from
Closed

WIP Add a shim for functions annotated with #[track_caller] (RFC 2091 #2/N) #65082

wants to merge 14 commits into from

Commits on Oct 5, 2019

  1. [RFC 2091] Add #[track_caller] attribute. 

    - The attribute is behind a feature gate.
- Error if both #[naked] and #[track_caller] are applied to the same function.
- Error if #[track_caller] is applied to a non-function item.
- Error if ABI is not "rust"
- Error if #[track_caller] is applied to a trait function.

Error codes and descriptions are pending.
    @ayosec @anp
    ayosec authored and anp committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    b77b557 View commit details
    Browse the repository at this point in the history

  2. track_caller run-pass test, lint cleanup, PR review.

    @anp
    anp committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    6edbfdc View commit details
    Browse the repository at this point in the history

  3. track_caller feature gate starts in 1.40.0. 

    Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
    @anp @Centril
    anp and Centril committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    43c1065 View commit details
    Browse the repository at this point in the history

  4. Mark #![feature(track_caller)] as incomplete.

    @anp
    anp committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    635ded0 View commit details
    Browse the repository at this point in the history

  5. track_caller error numbers and text.

    @anp
    anp committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    2e9400c View commit details
    Browse the repository at this point in the history

  6. track_caller tests account for incomplete feature warning.

    @anp
    anp committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    00df81c View commit details
    Browse the repository at this point in the history

  7. E0735 -> E0739 

    Prevents number collision with another approved PR.
    @anp
    anp committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    db7af2b View commit details
    Browse the repository at this point in the history

  8. E073[6-8] include failing code examples.

    @anp
    anp committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    532465b View commit details
    Browse the repository at this point in the history

  9. Expand E0738 to cover different cases.

    @anp
    anp committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    26ce8fe View commit details
    Browse the repository at this point in the history

  10. Update expected error output.

    @anp
    anp committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    11aece0 View commit details
    Browse the repository at this point in the history

  11. Prohibit #[track_caller] within trait impls as well as decls.

    @anp
    anp committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    fbeaec6 View commit details
    Browse the repository at this point in the history

  12. Clarify variable names when checking track_caller methods.

    @anp
    anp committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    0a87757 View commit details
    Browse the repository at this point in the history

  13. Add InstanceDef::ReifyShim for track_caller functions.

    @anp
    anp committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    c352eda View commit details
    Browse the repository at this point in the history

  14. Add Instance::resolve_for_fn_ptr

    @anp
    anp committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    311fa06 View commit details
    Browse the repository at this point in the history