Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill borrows from assignments after generating new borrows #64036

Merged
merged 1 commit into from
Sep 1, 2019
Merged

Kill borrows from assignments after generating new borrows #64036

merged 1 commit into from
Sep 1, 2019

Conversation

matthewjasper
Copy link
Contributor

Closes #63719

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 31, 2019
@estebank
Copy link
Contributor

estebank commented Sep 1, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Sep 1, 2019

📌 Commit c621919 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2019
@bors
Copy link
Contributor

bors commented Sep 1, 2019

⌛ Testing commit c621919 with merge 96a55f32435be8695885efea7461cca58bd41720...

@rust-highfive
Copy link
Collaborator

The job dist-x86_64-linux-alt of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Sep 1, 2019

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 1, 2019
@matthewjasper
Copy link
Contributor Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2019
@bors
Copy link
Contributor

bors commented Sep 1, 2019

⌛ Testing commit c621919 with merge d0677b9...

bors added a commit that referenced this pull request Sep 1, 2019
@bors
Auto merge of #64036 - matthewjasper:kill-borrows-on-self-assign, r=e…
d0677b9 
…stebank

Kill borrows from assignments after generating new borrows

Closes #63719
@bors
Copy link
Contributor

bors commented Sep 1, 2019

☀️ Test successful - checks-azure
Approved by: estebank
Pushing d0677b9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 1, 2019
@bors bors merged commit c621919 into rust-lang:master Sep 1, 2019
@matthewjasper matthewjasper deleted the kill-borrows-on-self-assign branch September 1, 2019 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strange E0505 error ... is this a bug?
4 participants
@matthewjasper @rust-highfive @estebank @bors