[WIP] fix libunwind #62622
Closed
[WIP] fix libunwind #62622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
mati865
reviewed
Jul 12, 2019
|
Thanks for the PR! This PR is unfortunately pretty light on the details. Neither the PR title nor description really gives any insight into what the compilation error looks like today, what this change is, and why the change fixes it. Could you expand the descriptions and/or give more detail about the issues you're encountering? |
|
Any breaking changes is not what I want it all.
|
fix compilation panic=abort for target i686-pc-windows-gnu on linux Update libunwind.rs Update libunwind.rs Update libunwind.rs
|
Rust currently ships |
|
|
Ok thanks for expanding the description! As you've discovered I don't think this is fixable without rustc changes itself. Even with xargo the compiler needs to configure LLVM and may need to change its codegen for sjlj exceptions. Do you want to leave this open in the meantime or shall we close this? |
|
@alexcrichton , I do not throw this PR. I look through some more possible solutions. I would like the solution to be as minimal and simple as possible. |
|
This probably isn't the best place to discuss why architectural design decisions are the way they are in Rust, I'd recommend starting a thread on internals.rust-lang.org for that. I don't think this is an actionable change without more changes to the compiler itself, so I'm inclined to close this while those are settled. |
|
Probably adding new targets for compile features is not good path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix compilation panic=abort for target i686-pc-windows-gnu on linux with w64-mingw32-gcc linker