Normalize use of backticks in compiler messages p2 #62472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in diagnostic error codes |
rust-highfive
added
the
S-waiting-on-review
|
@fakenine Can you cherry-pick the two first commits into different PRs? The last commit should ideally also be broken into more based on files/feature gates this is changing to make it easier to land the PRs. (Also, please avoid pinging people in commit messages, it generates more pings over time) |
fakenine
force-pushed
the
normalize_use_of_backticks_compiler_messages_p2
branch
from
85f1888
to
60a4938
Compare
|
@Centril Sure! Done for the first commit |
|
Thanks! @bors r+ rollup |
|
📌 Commit 60a4938 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 8, 2019
…_compiler_messages_p2, r=Centril Normalize use of backticks in compiler messages p2 normalize use of backticks in compiler messages for librustc_typecheck rust-lang#60532
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 8, 2019
…_compiler_messages_p2, r=Centril Normalize use of backticks in compiler messages p2 normalize use of backticks in compiler messages for librustc_typecheck rust-lang#60532
bors
added a commit
that referenced
this pull request
Jul 8, 2019
Rollup of 5 pull requests Successful merges: - #62356 (Implement Option::contains and Result::contains) - #62462 (Document `while` keyword) - #62472 (Normalize use of backticks in compiler messages p2) - #62477 (Re-add bootstrap attribute to libunwind for llvm-libunwind feature) - #62478 (normalize use of backticks for compiler messages in librustc_codegen) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
normalize use of backticks in compiler messages for librustc_typecheck
#60532