Check if the archive has already been added to avoid duplicates #62286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Centril
reviewed
Jul 2, 2019
cramertj
reviewed
Jul 2, 2019
|
r=me with nits fixed. |
|
r? @cramertj |
petrhosek
force-pushed
the
rustc-no-duplicate-archives
branch
2 times, most recently
from
cfe2fe9
to
35c70e6
Compare
tesuji
reviewed
Jul 2, 2019
This avoids adding archives multiple times, which results in duplicate objects in the resulting rlib, leading to symbol collision and link failures. This could happen when crate contains multiple link attributes that all reference the same archive.
petrhosek
force-pushed
the
rustc-no-duplicate-archives
branch
from
35c70e6
to
069c52f
Compare
|
@bors r+ |
|
📌 Commit 069c52f has been approved by |
bors
added
S-waiting-on-bors
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jul 3, 2019
…es, r=cramertj Check if the archive has already been added to avoid duplicates This avoids adding archives multiple times, which results in duplicate objects in the resulting rlib, leading to symbol collision and link failures. This could happen when crate contains multiple link attributes that all reference the same archive.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 4, 2019
…es, r=cramertj Check if the archive has already been added to avoid duplicates This avoids adding archives multiple times, which results in duplicate objects in the resulting rlib, leading to symbol collision and link failures. This could happen when crate contains multiple link attributes that all reference the same archive.
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jul 4, 2019
…es, r=cramertj Check if the archive has already been added to avoid duplicates This avoids adding archives multiple times, which results in duplicate objects in the resulting rlib, leading to symbol collision and link failures. This could happen when crate contains multiple link attributes that all reference the same archive.
Keruspe
added a commit
to Keruspe/rust
that referenced
this pull request
Jul 5, 2019
This was broken by rust-lang#62376 Since rust-lang#62286 is not in beta yet, we cannot remove those not(bootstrap) Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 7, 2019
…es, r=cramertj Check if the archive has already been added to avoid duplicates This avoids adding archives multiple times, which results in duplicate objects in the resulting rlib, leading to symbol collision and link failures. This could happen when crate contains multiple link attributes that all reference the same archive.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 7, 2019
…es, r=cramertj Check if the archive has already been added to avoid duplicates This avoids adding archives multiple times, which results in duplicate objects in the resulting rlib, leading to symbol collision and link failures. This could happen when crate contains multiple link attributes that all reference the same archive.
bors
added a commit
that referenced
this pull request
Jul 7, 2019
Rollup of 4 pull requests Successful merges: - #61883 (`non_ascii_idents` lint (part of RFC 2457)) - #62042 (Support stability and deprecation checking for all macros) - #62213 (rustdoc: set cfg(doctest) when collecting doctests) - #62286 (Check if the archive has already been added to avoid duplicates) Failed merges: r? @ghost
petrhosek
added a commit
to petrhosek/rust
that referenced
this pull request
Jul 7, 2019
This was removed in 8a7dded, but since rust-lang#62286 hasn't yet made it into beta, this is breaking the build with llvm-libunwind feature enabled. Furthemore, restrict the link attribute to Fuchsia and Linux, matching the logic in build.rs since llvm-libunwind feature isn't yet supported on other systems.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 8, 2019
Re-add bootstrap attribute to libunwind for llvm-libunwind feature This was removed in 8a7dded, but since rust-lang#62286 hasn't yet made it into beta, this is breaking the build with llvm-libunwind feature enabled. Furthemore, restrict the link attribute to Fuchsia and Linux, matching the logic in build.rs since llvm-libunwind feature isn't yet supported on other systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids adding archives multiple times, which results in duplicate
objects in the resulting rlib, leading to symbol collision and link
failures. This could happen when crate contains multiple link attributes
that all reference the same archive.