Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for short-hand init structs when suggesting conversion #61217

Merged
merged 1 commit into from
May 29, 2019

Conversation

estebank
Copy link
Contributor

Fix #52820.

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 26, 2019
@Centril
Copy link
Contributor

Centril commented May 29, 2019

LGTM 👍

r? @Centril @bors r+ rollup

@bors
Copy link
Contributor

bors commented May 29, 2019

📌 Commit 24b2e20 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 29, 2019
Centril added a commit to Centril/rust that referenced this pull request May 29, 2019
Account for short-hand init structs when suggesting conversion

Fix rust-lang#52820.
Centril added a commit to Centril/rust that referenced this pull request May 29, 2019
Account for short-hand init structs when suggesting conversion

Fix rust-lang#52820.
Centril added a commit to Centril/rust that referenced this pull request May 29, 2019
Account for short-hand init structs when suggesting conversion

Fix rust-lang#52820.
Centril added a commit to Centril/rust that referenced this pull request May 29, 2019
Account for short-hand init structs when suggesting conversion

Fix rust-lang#52820.
Centril added a commit to Centril/rust that referenced this pull request May 29, 2019
Account for short-hand init structs when suggesting conversion

Fix rust-lang#52820.
oli-obk added a commit to oli-obk/rust that referenced this pull request May 29, 2019
Account for short-hand init structs when suggesting conversion

Fix rust-lang#52820.
bors added a commit that referenced this pull request May 29, 2019
Rollup of 7 pull requests

Successful merges:

 - #60549 (do not print panic message on doctest failures)
 - #60885 (strip synstructure consts from compiler docs)
 - #61217 (Account for short-hand init structs when suggesting conversion)
 - #61261 (is_union returns ty to avoid computing it twice)
 - #61293 (Print const generics properly in rustdoc)
 - #61310 (split libcore::mem into multiple files)
 - #61313 (Simplify Set1::insert)

Failed merges:

r? @ghost
@bors bors merged commit 24b2e20 into rust-lang:master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conversion method suggestion is wrong given struct field init shorthand
5 participants