Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unneeded extern crates from build tools #60671

Merged
merged 1 commit into from
May 10, 2019

Conversation

euclio
Copy link
Contributor

@euclio euclio commented May 9, 2019

No description provided.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 9, 2019
@mark-i-m
Copy link
Member

mark-i-m commented May 9, 2019

I think @Centril had been overseeing the transition to edition 2018...

@Centril
Copy link
Contributor

Centril commented May 9, 2019

r? @Centril

@bors r+

@bors
Copy link
Contributor

bors commented May 9, 2019

📌 Commit b2f71fb has been approved by Centril

@rust-highfive rust-highfive assigned Centril and unassigned nikomatsakis May 9, 2019
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2019
Centril added a commit to Centril/rust that referenced this pull request May 9, 2019
remove unneeded `extern crate`s from build tools
bors added a commit that referenced this pull request May 10, 2019
Rollup of 8 pull requests

Successful merges:

 - #59348 (Clean up and add tests for slice drop shims)
 - #60188 (Identify when a stmt could have been parsed as an expr)
 - #60234 (std: Derive `Default` for `io::Cursor`)
 - #60618 (Comment ext::tt::transcribe)
 - #60648 (Skip codegen for one UI test with long file path)
 - #60671 (remove unneeded `extern crate`s from build tools)
 - #60675 (Remove the old await! macro)
 - #60676 (Fix async desugaring providing wrong input to procedural macros.)

Failed merges:

r? @ghost
@bors bors merged commit b2f71fb into rust-lang:master May 10, 2019
@bors
Copy link
Contributor

bors commented May 10, 2019

⌛ Testing commit b2f71fb with merge 03bd2f6...

@euclio euclio deleted the extern-crate branch May 10, 2019 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants