Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-variant layouts for generators #59897

Merged
merged 13 commits into from
May 4, 2019
Merged

Multi-variant layouts for generators #59897

merged 13 commits into from
May 4, 2019

Commits on Apr 25, 2019

  1. Update comment for liveness_of_locals

    @tmandry
    tmandry committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    52e4407 View commit details
    Browse the repository at this point in the history

  2. Test debuginfo of different var liveness in generators

    @tmandry
    tmandry committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    9e06f25 View commit details
    Browse the repository at this point in the history

  3. Define generator discriminant type in only one place

    @tmandry
    tmandry committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    70c1b6c View commit details
    Browse the repository at this point in the history

  4. Give GeneratorLayout a list of fields for each variant 

    But don't really use it yet.
    @tmandry
    tmandry committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    4de2d8a View commit details
    Browse the repository at this point in the history

  5. Support variantful generators 

    This allows generators to overlap fields using variants.
    @tmandry
    tmandry committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    5a7af54 View commit details
    Browse the repository at this point in the history

  6. Describe generator variants in debuginfo

    @tmandry
    tmandry committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    961ba95 View commit details
    Browse the repository at this point in the history

  7. Make generator object debuginfo easier to read

    @tmandry
    tmandry committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    6e2e17d View commit details
    Browse the repository at this point in the history

  8. Include generator locals as field names in debuginfo

    @tmandry
    tmandry committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    f772c39 View commit details
    Browse the repository at this point in the history

  9. Generalize discriminant info calls for generators and ADTs

    @tmandry
    tmandry committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    b8f6de4 View commit details
    Browse the repository at this point in the history

  10. Preserve visibility scopes in stored generator locals 

    Unfortunately, this didn't have quite the effect I was hoping for.
Locals still appear visible at every point in the function, regardless
of scopes. I suspect all the rewriting of the MIR we do for the
generator transform makes these scopes less useful.

I didn't observe any regressions in behavior, but it's possible that
this change is wrong without additional changes to the MIR.
    @tmandry
    tmandry committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    9ef2c30 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2019

  1. Make variant_fields inner an IndexVec

    @tmandry
    tmandry committed May 3, 2019
    Configuration menu
    Copy the full SHA
    f7c2f24 View commit details
    Browse the repository at this point in the history

  2. Split out debuginfo from type info in MIR GeneratorLayout

    @tmandry
    tmandry committed May 3, 2019
    Configuration menu
    Copy the full SHA
    15dbe65 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2019

  1. Address review comments

    @tmandry
    tmandry committed May 4, 2019
    Configuration menu
    Copy the full SHA
    77a6d29 View commit details
    Browse the repository at this point in the history