Adds help message in error for invalid `impl for T` syntax #58872

repnop · 2019-03-02T14:33:18Z

rust-highfive · 2019-03-02T14:33:28Z

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2019-03-02T14:42:07Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:070aa3f4:start=1551537281086150125,finish=1551537365809847584,duration=84723697459
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:05:35]    Compiling rustc_errors v0.0.0 (/checkout/src/librustc_errors)
[00:05:48] error: incorrect close delimiter: `}`
[00:05:48]     --> src/libsyntax/parse/parser.rs:6728:9
[00:05:48]      |
[00:05:48] 6722 |         let ty_first = self.parse_ty().map_err(|mut err|
[00:05:48]      |                                               - un-closed delimiter
[00:05:48] 6728 |         })?;
[00:05:48]      |         ^ incorrect close delimiter
[00:05:48] 
[00:05:48] error: incorrect close delimiter: `)`
---
travis_time:end:10d63392:start=1551537724633672625,finish=1551537724638779306,duration=5106681
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:25326619
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:03c81ce0
travis_time:start:03c81ce0
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:35d5f34c
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

tesuji · 2019-03-02T16:19:08Z

Missing a ui test for this PR?

repnop · 2019-03-02T17:35:43Z

I'll add one shortly, thanks for the reminder :)

rust-highfive · 2019-03-03T18:46:27Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:17e2ad60:start=1551637964219917659,finish=1551638039994208612,duration=75774290953
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---

[00:03:19] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:20] tidy error: /checkout/src/test/ui/issues/issue-56031.rs: missing trailing newline
[00:03:21] some tidy checks failed
[00:03:21] 
[00:03:21] 
[00:03:21] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:03:21] 
[00:03:21] 
[00:03:21] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:21] Build completed unsuccessfully in 0:00:46
[00:03:21] Build completed unsuccessfully in 0:00:46
[00:03:21] make: *** [tidy] Error 1
[00:03:21] Makefile:68: recipe for target 'tidy' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:003bf524
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sun Mar  3 18:37:30 UTC 2019
---
travis_time:end:064bd77c:start=1551638251829217513,finish=1551638251834586237,duration=5368724
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1419aa30
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1ec33da4
travis_time:start:1ec33da4
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0cbd16cb
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

tesuji · 2019-03-04T03:43:23Z

src/test/ui/issues/issue-56031.rs

+
+impl for T {}
+
+fn main() {}


Missing a newline here

rust-highfive · 2019-03-05T02:12:58Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:23442358:start=1551747703021913513,finish=1551747776395586629,duration=73373673116
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[01:08:03] .................................................................................................... 2600/5429
[01:08:07] .................................................................................................... 2700/5429
[01:08:11] .................................................................................................... 2800/5429
[01:08:15] .................................................................................................... 2900/5429
[01:08:19] ......................F............................................................................. 3000/5429
[01:08:26] .................................................................................................... 3200/5429
[01:08:29] ...............................................................i.................................... 3300/5429
[01:08:33] .................................................................................................... 3400/5429
[01:08:36] ...................................ii...i..ii....................................................... 3500/5429
---
[01:09:48] failures:
[01:09:48] 
[01:09:48] ---- [ui] ui/issues/issue-56031.rs stdout ----
[01:09:48] 
[01:09:48] error: /checkout/src/test/ui/issues/issue-56031.rs:3: unexpected error: '3:10: 3:11: expected `<`, found `T`'
[01:09:48] error: 1 unexpected errors found, 0 expected errors not found
[01:09:48] status: exit code: 1
[01:09:48] status: exit code: 1
[01:09:48] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-56031.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-56031/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-56031/auxiliary" "-A" "unused"
[01:09:48]     Error {
[01:09:48]         line_num: 3,
[01:09:48]         kind: Some(
[01:09:48]             Error
[01:09:48]             Error
[01:09:48]         ),
[01:09:48]         msg: "3:10: 3:11: expected `<`, found `T`"
[01:09:48] ]
[01:09:48] 
[01:09:48] thread '[ui] ui/issues/issue-56031.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:1378:13
[01:09:48] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
---
[01:09:48] 
[01:09:48] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:496:22
[01:09:48] 
[01:09:48] 
[01:09:48] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:09:48] 
[01:09:48] 
[01:09:48] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:09:48] Build completed unsuccessfully in 0:04:13
[01:09:48] Build completed unsuccessfully in 0:04:13
[01:09:48] make: *** [check] Error 1
[01:09:48] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0c060be5
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Mar  5 02:12:52 UTC 2019
---
travis_time:end:0cd29e28:start=1551751974078069165,finish=1551751974082431320,duration=4362155
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0c211800
$ ln -s . checkout && for CORE in o

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

tesuji · 2019-03-07T05:15:12Z

ping @petrochenkov

petrochenkov · 2019-03-07T21:26:21Z

I made some tweaks to improve recovery.

@bors r+

bors · 2019-03-07T21:26:22Z

📌 Commit e19b228 has been approved by petrochenkov

bors · 2019-03-07T21:26:23Z

🌲 The tree is currently closed for pull requests below priority 500, this pull request will be tested once the tree is reopened

repnop · 2019-03-07T23:40:24Z

Great! Thanks @petrochenkov 👍

…rochenkov Adds help message in error for invalid `impl for T` syntax Fixes rust-lang#56031.

bors · 2019-03-18T08:03:13Z

⌛ Testing commit e19b228 with merge cd45b19...

Adds help message in error for invalid `impl for T` syntax Fixes #56031.

bors · 2019-03-18T11:11:12Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: petrochenkov
Pushing cd45b19 to master...

rust-highfive assigned michaelwoerister Mar 2, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 2, 2019

tesuji reviewed Mar 4, 2019

View reviewed changes

src/test/ui/issues/issue-56031.rs Outdated

impl for T {}

fn main() {}

Copy link

Contributor

tesuji Mar 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a newline here

petrochenkov assigned petrochenkov and unassigned michaelwoerister Mar 4, 2019

repnop force-pushed the diagnostic-fix-56031 branch from c3406c0 to b9f24d1 Compare March 5, 2019 01:00

repnop and others added 2 commits March 7, 2019 23:18

Adds diagnostic message and UI test.

00887f3

Improve recovery for missing trait in a trait impl

e19b228

petrochenkov force-pushed the diagnostic-fix-56031 branch from b9f24d1 to e19b228 Compare March 7, 2019 21:25

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 7, 2019

Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2019

Rollup merge of rust-lang#58872 - rep-nop:diagnostic-fix-56031, r=pet…

f847d3d

…rochenkov Adds help message in error for invalid `impl for T` syntax Fixes rust-lang#56031.

Centril mentioned this pull request Mar 10, 2019

Rollup of 16 pull requests #59066

Closed

Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2019

Rollup merge of rust-lang#58872 - rep-nop:diagnostic-fix-56031, r=pet…

f721977

…rochenkov Adds help message in error for invalid `impl for T` syntax Fixes rust-lang#56031.

Centril mentioned this pull request Mar 10, 2019

Rollup of 17 pull requests #59067

Closed

Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2019

Rollup merge of rust-lang#58872 - rep-nop:diagnostic-fix-56031, r=pet…

81920ff

…rochenkov Adds help message in error for invalid `impl for T` syntax Fixes rust-lang#56031.

Centril mentioned this pull request Mar 10, 2019

Rollup of 16 pull requests #59069

Closed

Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2019

Rollup merge of rust-lang#58872 - rep-nop:diagnostic-fix-56031, r=pet…

7e511e0

…rochenkov Adds help message in error for invalid `impl for T` syntax Fixes rust-lang#56031.

Centril mentioned this pull request Mar 10, 2019

Rollup of 17 pull requests #59075

Closed

Centril added a commit to Centril/rust that referenced this pull request Mar 11, 2019

Rollup merge of rust-lang#58872 - rep-nop:diagnostic-fix-56031, r=pet…

90f7ffc

…rochenkov Adds help message in error for invalid `impl for T` syntax Fixes rust-lang#56031.

Centril mentioned this pull request Mar 11, 2019

Rollup of 15 pull requests #59081

Closed

bors added a commit that referenced this pull request Mar 18, 2019

Auto merge of #58872 - rep-nop:diagnostic-fix-56031, r=petrochenkov

cd45b19

Adds help message in error for invalid `impl for T` syntax Fixes #56031.

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 18, 2019

bors merged commit e19b228 into rust-lang:master Mar 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds help message in error for invalid `impl for T` syntax #58872

Adds help message in error for invalid `impl for T` syntax #58872

repnop commented Mar 2, 2019

rust-highfive commented Mar 2, 2019

rust-highfive commented Mar 2, 2019

tesuji commented Mar 2, 2019

repnop commented Mar 2, 2019

rust-highfive commented Mar 3, 2019

tesuji Mar 4, 2019

rust-highfive commented Mar 5, 2019

tesuji commented Mar 7, 2019

petrochenkov commented Mar 7, 2019

bors commented Mar 7, 2019

bors commented Mar 7, 2019

repnop commented Mar 7, 2019

bors commented Mar 18, 2019

bors commented Mar 18, 2019

Adds help message in error for invalid impl for T syntax #58872

Adds help message in error for invalid impl for T syntax #58872

Conversation

repnop commented Mar 2, 2019

rust-highfive commented Mar 2, 2019

rust-highfive commented Mar 2, 2019

tesuji commented Mar 2, 2019

repnop commented Mar 2, 2019

rust-highfive commented Mar 3, 2019

tesuji Mar 4, 2019

Choose a reason for hiding this comment

rust-highfive commented Mar 5, 2019

tesuji commented Mar 7, 2019

petrochenkov commented Mar 7, 2019

bors commented Mar 7, 2019

bors commented Mar 7, 2019

repnop commented Mar 7, 2019

bors commented Mar 18, 2019

bors commented Mar 18, 2019

Adds help message in error for invalid `impl for T` syntax #58872

Adds help message in error for invalid `impl for T` syntax #58872