Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement leak check in terms of universes #58592

Merged
merged 7 commits into from
Feb 22, 2019
Merged

Re-implement leak check in terms of universes #58592

merged 7 commits into from
Feb 22, 2019

Commits on Feb 21, 2019

  1. s/skol_/placeholder_/

    @nikomatsakis
    nikomatsakis committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    3cd286b View commit details
    Browse the repository at this point in the history

  2. reintroduce commit_if_ok call into higher_ranked_sub

    @nikomatsakis
    nikomatsakis committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    6cb4ffb View commit details
    Browse the repository at this point in the history

  3. reintroduce commit_if_ok calls to subtype_predicate

    @nikomatsakis
    nikomatsakis committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    2cbe07b View commit details
    Browse the repository at this point in the history

  4. introduce a dummy leak check and invoke it in all the right places 

    This set of diffs was produced by combing through
b68fad6 and seeing where the
`leak_check` used to be invoked and how.
    @nikomatsakis
    nikomatsakis committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    0c94ea0 View commit details
    Browse the repository at this point in the history

  5. restore the actual leak-check

    @nikomatsakis
    nikomatsakis committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    561ce44 View commit details
    Browse the repository at this point in the history

  6. update test files to reflect new output 

    One surprise: old-lub-glb-object.rs, may indicate a bug
    @nikomatsakis
    nikomatsakis committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    21e9478 View commit details
    Browse the repository at this point in the history

  7. partially revert 904a0bd 

    This preserves the error you currently get on stable for the
old-lub-glb-object.rs test.
    @nikomatsakis
    nikomatsakis committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    33d3598 View commit details
    Browse the repository at this point in the history