Check user type annotations for range patterns. #58371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
davidtwco
force-pushed
the
issue-58299
branch
from
b133af3
to
1ef561c
Compare
This comment has been minimized.
This comment has been minimized.
davidtwco
force-pushed
the
issue-58299
branch
from
1ef561c
to
89da53f
Compare
davidtwco
force-pushed
the
issue-58299
branch
from
89da53f
to
ca4c842
Compare
|
@bors r+ |
|
📌 Commit ca4c842c0d9d689ecad77a24d8dd73548a57eb75 has been approved by |
bors
added
S-waiting-on-bors
arielb1
reviewed
Feb 12, 2019
|
Actually, I'll rather want a comment @bors r- |
bors
added
S-waiting-on-author
|
r=me with that comment |
This commit builds on the fix from rust-lang#58161 (which fixed miscompilation caused by the introduction of `AscribeUserType` patterns for associated constants) to start checking these patterns are well-formed for ranges (previous fix just ignored them so that miscompilation wouldn't occur).
davidtwco
force-pushed
the
issue-58299
branch
from
ca4c842
to
ee82d09
Compare
|
@bors r=arielb1 |
|
📌 Commit ee82d09 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Feb 14, 2019
Check user type annotations for range patterns. Fixes rust-lang#58299. This PR builds on the fix from rust-lang#58161 (which fixed miscompilation caused by the introduction of `AscribeUserType` patterns for associated constants) to start checking these patterns are well-formed for ranges (previous fix just ignored them so that miscompilation wouldn't occur). r? @arielb1
bors
added a commit
that referenced
this pull request
Feb 14, 2019
Rollup of 7 pull requests Successful merges: - #58309 (Add more profiler events) - #58347 (Closure bounds fixes) - #58365 (Add an option to print the status of incremental tasks / dep nodes after running them) - #58371 (Check user type annotations for range patterns.) - #58378 (rustc: Implement incremental "fat" LTO) - #58407 (specify "upper camel case" in style lint) - #58449 (Notify @topecongiro when the state of rustfmt has changed) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58299.
This PR builds on the fix from #58161 (which fixed miscompilation
caused by the introduction of
AscribeUserTypepatterns for associatedconstants) to start checking these patterns are well-formed for ranges
(previous fix just ignored them so that miscompilation wouldn't occur).
r? @arielb1