Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build LLVM with -static-libstdc++ on dist builds #57429

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

alexcrichton
Copy link
Member

This commit is intended on fixing a regression from #57286 where the
distributed LLVM shared library unfortunately depends on a dynamic copy
of libstdc++, meaning we're no longer as binary compatible as we
thought! This tweaks the build of LLVM as out distribution is slightly
different now, and is hoped to fix the issue.

Closes #57426

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 7, 2019
@Mark-Simulacrum
Copy link
Member

@bors r+ p=1 (unbreaks nightly for some distros)

@bors
Copy link
Contributor

bors commented Jan 7, 2019

📌 Commit 444bc74 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2019
@bors
Copy link
Contributor

bors commented Jan 7, 2019

⌛ Testing commit 444bc74 with merge 94b991d...

bors added a commit that referenced this pull request Jan 7, 2019
Build LLVM with -static-libstdc++ on dist builds

This commit is intended on fixing a regression from #57286 where the
distributed LLVM shared library unfortunately depends on a dynamic copy
of libstdc++, meaning we're no longer as binary compatible as we
thought! This tweaks the build of LLVM as out distribution is slightly
different now, and is hoped to fix the issue.

Closes #57426
@bors
Copy link
Contributor

bors commented Jan 7, 2019

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 7, 2019
@rust-highfive
Copy link
Collaborator

The job dist-x86_64-netbsd of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:26:53] [ 55%] Built target LLVMAsmPrinter
[01:26:53] Scanning dependencies of target LLVMHello
[01:26:53] [ 55%] Building CXX object lib/Transforms/Hello/CMakeFiles/LLVMHello.dir/Hello.cpp.o
[01:26:55] [ 55%] Linking CXX shared module ../../LLVMHello.so
[01:26:55] /x-tools/x86_64-unknown-netbsd/lib/gcc/x86_64--netbsd/4.8.4/../../../../x86_64--netbsd/bin/ld: /x-tools/x86_64-unknown-netbsd/sysroot/usr/lib/libstdc++.a(new_op.o): relocation R_X86_64_32S against `_ZTVSt9bad_alloc' can not be used when making a shared object; recompile with -fPIC
[01:26:55] /x-tools/x86_64-unknown-netbsd/sysroot/usr/lib/libstdc++.a: could not read symbols: Bad value
[01:26:55] collect2: error: ld returned 1 exit status
[01:26:55] make[2]: *** [lib/LLVMHello.so] Error 1
[01:26:55] make[1]: *** [lib/Transforms/Hello/CMakeFiles/LLVMHello.dir/all] Error 2
[01:26:55] make[1]: *** Waiting for unfinished jobs....
[01:26:56] [ 55%] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineFunctionPass.cpp.o
[01:26:57] [ 55%] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineFunctionPrinterPass.cpp.o
[01:27:00] [ 55%] Linking CXX static library ../../libLLVMInstCombine.a
[01:27:00] [ 55%] Built target LLVMInstCombine
---
[01:29:41] [ 59%] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/WinEHPrepare.cpp.o
[01:29:42] [ 59%] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/XRayInstrumentation.cpp.o
[01:29:48] [ 59%] Linking CXX static library ../libLLVMCodeGen.a
[01:29:48] [ 59%] Built target LLVMCodeGen
[01:29:48] make: *** [all] Error 2
[01:29:48] command did not execute successfully, got: exit code: 2
[01:29:48] 
[01:29:48] 
[01:29:48] build script failed, must exit now', /cargo/registry/src/github.51.al-1ecc6299db9ec823/cmake-0.1.33/src/lib.rs:773:5
[01:29:48]  finished in 1520.231
[01:29:48] travis_fold:end:llvm

[01:29:48] travis_time:end:llvm:start=1546903849849886532,finish=1546905370081854541,duration=1520231968009
---
travis_time:end:194365f8:start=1546905371507795050,finish=1546905371529050933,duration=21255883
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:01a52eec
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:00f33ed0
travis_time:start:00f33ed0
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:08baf514
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

This commit is intended on fixing a regression from rust-lang#57286 where the
distributed LLVM shared library unfortunately depends on a dynamic copy
of libstdc++, meaning we're no longer as binary compatible as we
thought! This tweaks the build of LLVM as out distribution is slightly
different now, and is hoped to fix the issue.

Closes rust-lang#57426
@alexcrichton
Copy link
Member Author

@bors: r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Jan 8, 2019

📌 Commit d585553 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2019
@bors
Copy link
Contributor

bors commented Jan 8, 2019

⌛ Testing commit d585553 with merge b221347a94ca53788edded0f2db902bd1d7c3d81...

@bors
Copy link
Contributor

bors commented Jan 8, 2019

💔 Test failed - status-travis

@rust-highfive
Copy link
Collaborator

The job dist-i686-apple of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 8, 2019
@kennytm
Copy link
Member

kennytm commented Jan 8, 2019

@bors retry

3 hour timeout, probably due to cache invalidation.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2019
@bors
Copy link
Contributor

bors commented Jan 8, 2019

⌛ Testing commit d585553 with merge 2cb7cdc...

bors added a commit that referenced this pull request Jan 8, 2019
Build LLVM with -static-libstdc++ on dist builds

This commit is intended on fixing a regression from #57286 where the
distributed LLVM shared library unfortunately depends on a dynamic copy
of libstdc++, meaning we're no longer as binary compatible as we
thought! This tweaks the build of LLVM as out distribution is slightly
different now, and is hoped to fix the issue.

Closes #57426
@bors
Copy link
Contributor

bors commented Jan 8, 2019

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing 2cb7cdc to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly broken on older libstdc++
6 participants