Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small deriving-related cleanups #5513

Merged
merged 2 commits into from Mar 26, 2013
Merged

Small deriving-related cleanups #5513

merged 2 commits into from Mar 26, 2013

Conversation

ghost
Copy link

@ghost ghost commented Mar 23, 2013

This removes some explicit implementations of Eq in favor of #[deriving(Eq)] and derives Clone for a few core types.

@ghost
Copy link
Author

ghost commented Mar 23, 2013

The test failures don't appear to have anything to do with this patch.

@thestinger
Copy link
Contributor

@apasel422: yeah, they're unrelated - incoming needs some tests fixed atm

@ghost
Copy link
Author

ghost commented Mar 25, 2013

I think that the test cases in question were fixed and that merging this can be attempted again.

bors added a commit that referenced this pull request Mar 26, 2013
This removes some explicit implementations of `Eq` in favor of `#[deriving(Eq)]` and derives `Clone` for a few core types.
@bors bors closed this Mar 26, 2013
@bors bors merged commit 45677ee into rust-lang:incoming Mar 26, 2013
@ghost ghost deleted the deriving branch March 26, 2013 11:27
oli-obk pushed a commit to oli-obk/rust that referenced this pull request May 2, 2020
fix clippy_dev exit status and make regex match again

changelog: none

Fixes rust-lang#5510

r? @phansch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants