Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make typechecker compositional #5461

Closed
wants to merge 2 commits into from
Closed

Make typechecker compositional #5461

wants to merge 2 commits into from

Commits on Mar 21, 2013

  1. Make typechecker compositional 

    The typechecker previously passed around a boolean return flag to
indicate whether it saw something with type _|_ (that is, something
it knows at compile-time will definitely diverge) and also had some
manual checks for the `ty_err` pseudo-type that represents a previous
type error. This was because the typing rules implemented by the
typechecker didn't properly propagate _|_ and ty_err. I fixed it.

This also required changing expected error messages in a few tests,
as now we're printing out fewer derived errors -- in fact, at this
point we should print out no derived errors, so report any that
you see (ones that include "[type error]") as bugs.
    @catamorphism
    catamorphism committed Mar 21, 2013
    3 Configuration menu
    Copy the full SHA
    db00362 View commit details
    Browse the repository at this point in the history

  2. rustc: Comments only - explain the invariant about ty_err and ty_bot … 

    …a little
    @catamorphism
    catamorphism committed Mar 21, 2013
    5 Configuration menu
    Copy the full SHA
    f36f9fc View commit details
    Browse the repository at this point in the history