Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostic suggest drop in reverse #51638

Merged
merged 2 commits into from
Jun 20, 2018

Conversation

spastorino
Copy link
Member

Closes #51195

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 19, 2018
@spastorino
Copy link
Member Author

r? @nikomatsakis

@spastorino spastorino force-pushed the diagnostic-suggest-drop-in-reverse branch 3 times, most recently from 09777ff to 893552b Compare June 19, 2018 19:11
@spastorino spastorino force-pushed the diagnostic-suggest-drop-in-reverse branch from 893552b to d1619ba Compare June 20, 2018 00:24
@spastorino spastorino force-pushed the diagnostic-suggest-drop-in-reverse branch from d1619ba to d3defca Compare June 20, 2018 00:25
@rust-lang rust-lang deleted a comment from bors Jun 20, 2018
@rust-lang rust-lang deleted a comment from rust-highfive Jun 20, 2018
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jun 20, 2018

📌 Commit d3defca has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2018
@bors
Copy link
Contributor

bors commented Jun 20, 2018

⌛ Testing commit d3defca with merge 7d313ea...

bors added a commit that referenced this pull request Jun 20, 2018
… r=nikomatsakis

Diagnostic suggest drop in reverse

Closes #51195
@bors
Copy link
Contributor

bors commented Jun 20, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 7d313ea to master...

@bors bors merged commit d3defca into rust-lang:master Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants