Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace new-in-1.26 ParsePathError with ! #49404

Closed
wants to merge 1 commit into from
Closed

Replace new-in-1.26 ParsePathError with ! #49404

wants to merge 1 commit into from

Conversation

scottmcm
Copy link
Member

@scottmcm scottmcm commented Mar 27, 2018 •
edited
Loading

This is the "definitely ok because it only changes things that have never been released in stable" version of #49039. Posting this in case it's decided there that changing string::ParseError is undesirable.

r? @alexcrichton

@scottmcm
Replace new-in-1.26 ParsePathError with !
97b7754 
This has never been stable, so we can just get rid of the nominal type.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 27, 2018
@scottmcm scottmcm mentioned this pull request Mar 27, 2018
Closed
@kennytm kennytm added beta-nominated Nominated for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Apr 3, 2018
@kennytm
Copy link
Member

kennytm commented Apr 3, 2018

Blocked by decision in #49593.

@kennytm kennytm added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2018
@TimNN TimNN added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Apr 17, 2018
@TimNN TimNN added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Apr 24, 2018
@bors
Copy link
Contributor

bors commented May 3, 2018

☔ The latest upstream changes (presumably #50413) made this pull request unmergeable. Please resolve the merge conflicts.

@kennytm
Copy link
Member

kennytm commented May 3, 2018

ParsePathError has been reverted by #50401, and thus this PR is no longer needed.

@kennytm kennytm closed this May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@scottmcm @kennytm @bors @alexcrichton @TimNN @rust-highfive