Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a -Z flag for LLVM align attributes on arguments #49122

Merged
merged 1 commit into from
Mar 24, 2018

Conversation

scottmcm
Copy link
Member

LLVM seems to still put the assume calls in when inlining, so this probably isn't in a place where it can be turned on by default, but it's interesting to experiment with.

For example, this makes mem::swap::<u64x8> be 8x vmovaps ymm instead of 16x vmovups xmm, on my cpu.

LLVM seems to still put the assume calls in when inlining, so this probably isn't in a place where it can be turned on by default, but it's interesting to experiment with.

For example, this makes `swap::<u64x8>` be 8x `vmovaps	ymm` instead of 16x `vmovups	xmm`, on my cpu.
@rust-highfive
Copy link
Collaborator

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 17, 2018
@cramertj
Copy link
Member

@bors r+

@cramertj
Copy link
Member

@scottmcm Can you create an issue tracking this flag?

@scottmcm
Copy link
Member Author

scottmcm commented Mar 19, 2018

Tracking issue added: #49185

(oops, don't know why what I typed before triggered the bot)

@bors
Copy link
Contributor

bors commented Mar 19, 2018

@scottmcm: 🔑 Insufficient privileges: Not in reviewers

@bors
Copy link
Contributor

bors commented Mar 19, 2018

@scottmcm: 🔑 Insufficient privileges: not in try users

@scottmcm scottmcm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 22, 2018
@scottmcm
Copy link
Member Author

Hmm, there's no bors comment ACKing the r+ here. Does it need to be done again since the bot was broken?

@rust-lang rust-lang deleted a comment from bors Mar 22, 2018
@rust-lang rust-lang deleted a comment from bors Mar 22, 2018
@cramertj
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 22, 2018

📌 Commit b498192 has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2018
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 23, 2018
Add a -Z flag for LLVM align attributes on arguments

LLVM seems to still put the assume calls in when inlining, so this probably isn't in a place where it can be turned on by default, but it's interesting to experiment with.

For example, this makes `mem::swap::<u64x8>` be 8x `vmovaps	ymm` instead of 16x `vmovups	xmm`, on my cpu.
kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2018
Add a -Z flag for LLVM align attributes on arguments

LLVM seems to still put the assume calls in when inlining, so this probably isn't in a place where it can be turned on by default, but it's interesting to experiment with.

For example, this makes `mem::swap::<u64x8>` be 8x `vmovaps	ymm` instead of 16x `vmovups	xmm`, on my cpu.
kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2018
Add a -Z flag for LLVM align attributes on arguments

LLVM seems to still put the assume calls in when inlining, so this probably isn't in a place where it can be turned on by default, but it's interesting to experiment with.

For example, this makes `mem::swap::<u64x8>` be 8x `vmovaps	ymm` instead of 16x `vmovups	xmm`, on my cpu.
bors added a commit that referenced this pull request Mar 24, 2018
@bors bors merged commit b498192 into rust-lang:master Mar 24, 2018
@scottmcm scottmcm deleted the z-align-attr branch March 24, 2018 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants