Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize use_nested_groups #47948

Merged
merged 1 commit into from
Feb 6, 2018
Merged

Stabilize use_nested_groups #47948

merged 1 commit into from
Feb 6, 2018

Conversation

pietroalbini
Copy link
Member

As requested in #44494. Documentation PRs already sent.

@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Feb 1, 2018

📌 Commit e532265 has been approved by petrochenkov

@petrochenkov petrochenkov added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 1, 2018
@kennytm kennytm added the relnotes Marks issues that should be documented in the release notes of the next release. label Feb 2, 2018
@Mark-Simulacrum
Copy link
Member

@bors rollup

This was referenced Feb 3, 2018
Closed
Closed
@kennytm kennytm mentioned this pull request Feb 4, 2018
Merged
@bors
Copy link
Contributor

bors commented Feb 5, 2018

☔ The latest upstream changes (presumably #47998) made this pull request unmergeable. Please resolve the merge conflicts.

@petrochenkov
Copy link
Contributor

Needs rebase.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 5, 2018
@pietroalbini
Copy link
Member Author

Rebased.

@pietroalbini pietroalbini added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 5, 2018
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Feb 5, 2018

📌 Commit 01f0814 has been approved by petrochenkov

@petrochenkov petrochenkov added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2018
@petrochenkov
Copy link
Contributor

@bors delegate+

@bors
Copy link
Contributor

bors commented Feb 5, 2018

✌️ @pietroalbini can now approve this pull request

kennytm added a commit to kennytm/rust that referenced this pull request Feb 5, 2018
@kennytm
Rollup merge of rust-lang#47948 - pietroalbini:use-nested-groups-stab…
55aef3c 
…ilize, r=petrochenkov

Stabilize use_nested_groups

As requested in rust-lang#44494. Documentation PRs already sent.
@kennytm kennytm mentioned this pull request Feb 5, 2018
Merged
bors added a commit that referenced this pull request Feb 6, 2018
@bors
Auto merge of #48017 - kennytm:rollup, r=kennytm
b224fc8 
Rollup of 10 pull requests

- Successful merges: #46030, #47496, #47543, #47704, #47753, #47807, #47948, #47959, #48003, #48007
- Failed merges:
@bors bors merged commit 01f0814 into rust-lang:master Feb 6, 2018
@stanislav-tkach stanislav-tkach mentioned this pull request Mar 30, 2018
Merged
@pietroalbini pietroalbini deleted the use-nested-groups-stabilize branch May 13, 2018 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pietroalbini @rust-highfive @petrochenkov @bors @Mark-Simulacrum @kennytm @michaelwoerister