Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More general on_unimplemented, with uses in Try #44191

Merged
merged 7 commits into from
Sep 3, 2017
Merged

More general on_unimplemented, with uses in Try #44191

merged 7 commits into from
Sep 3, 2017

Commits on Sep 3, 2017

  1. refactor and centralize on_unimplemented parsing

    @arielb1
    arielb1 committed Sep 3, 2017
    Configuration menu
    Copy the full SHA
    243aa12 View commit details
    Browse the repository at this point in the history

  2. move the on_unimplemented logic to its own file

    @arielb1
    arielb1 committed Sep 3, 2017
    Configuration menu
    Copy the full SHA
    cf07ebd View commit details
    Browse the repository at this point in the history

  3. implement improved on_unimplemented directives

    @arielb1
    arielb1 committed Sep 3, 2017
    Configuration menu
    Copy the full SHA
    6866aea View commit details
    Browse the repository at this point in the history

  4. enable desugaring-sensitive error messages and use them in Try 

    Maybe I should allow error messages to check the *specific* desugaring?
Thanks @huntiep for the idea!
    @arielb1
    arielb1 committed Sep 3, 2017
    Configuration menu
    Copy the full SHA
    02b3ae6 View commit details
    Browse the repository at this point in the history

  5. address review comments

    @arielb1
    arielb1 committed Sep 3, 2017
    Configuration menu
    Copy the full SHA
    6dec953 View commit details
    Browse the repository at this point in the history

  6. on_unimplemented: add method-name checks and use them in Try

    @arielb1
    arielb1 committed Sep 3, 2017
    Configuration menu
    Copy the full SHA
    efa09ea View commit details
    Browse the repository at this point in the history

  7. add error message for the other case too

    @arielb1
    arielb1 committed Sep 3, 2017
    Configuration menu
    Copy the full SHA
    291b4ed View commit details
    Browse the repository at this point in the history