explanatory error on --print target-spec-json without unstable options
#43260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
src/librustc/session/config.rs
Outdated
| @@ -1600,6 +1600,11 @@ pub fn build_session_options_and_crate_config(matches: &getopts::Matches) | |||
| "code-models" => PrintRequest::CodeModels, | |||
| "target-spec-json" if nightly_options::is_unstable_enabled(matches) | |||
| => PrintRequest::TargetSpec, | |||
| "target-spec-json" if !nightly_options::is_unstable_enabled(matches) => { | |||
There was a problem hiding this comment.
Could you unify the if statement here, making it an if-else statement?
Mark-Simulacrum
added
the
S-waiting-on-review
|
r+ modulo that nit |
zackmdavis
force-pushed
the
print_target_spec_json_unstable_options_error
branch
from
20072cf
to
c6a2399
Compare
|
(force-push addresses nit) |
|
@bors r=arielb1 |
|
📌 Commit c6a2399 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 20, 2017
…ions_error, r=arielb1 explanatory error on `--print target-spec-json` without unstable options  Resolves #41683.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #41683.