Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make lint on-by-default/implied-by messages appear only once #42919

Merged
merged 1 commit into from
Jun 29, 2017
Merged

make lint on-by-default/implied-by messages appear only once #42919

merged 1 commit into from
Jun 29, 2017

Conversation

zackmdavis
Copy link
Member

From review discussion on #38103 (#38103 (comment)).

we_heard

r? @nikomatsakis

@arielb1 arielb1 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 27, 2017
@arielb1
Copy link
Contributor

arielb1 commented Jun 27, 2017

r? @eddyb

@eddyb
Copy link
Member

eddyb commented Jun 28, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Jun 28, 2017

📌 Commit 32b8579 has been approved by eddyb

@arielb1
Copy link
Contributor

arielb1 commented Jun 29, 2017

@bors rollup

arielb1 pushed a commit to arielb1/rust that referenced this pull request Jun 29, 2017
Rollup merge of rust-lang#42919 - zackmdavis:once_again_we_heard_you_…
bfe0098 
…the_first_time, r=eddyb

make lint on-by-default/implied-by messages appear only once

From review discussion on rust-lang#38103 (rust-lang#38103 (comment)).

![we_heard](https://user-images.githubusercontent.com/1076988/27564103-6284b78e-5a8a-11e7-9d35-f7f297ca9573.png)

r? @nikomatsakis
@arielb1 arielb1 mentioned this pull request Jun 29, 2017
Merged
bors added a commit that referenced this pull request Jun 29, 2017
@bors
Auto merge of #42964 - arielb1:rollup, r=arielb1
7acce37 
Rollup of 12 pull requests

- Successful merges: #42219, #42831, #42832, #42884, #42886, #42901, #42919, #42920, #42946, #42953, #42955, #42958
- Failed merges:
@bors bors merged commit 32b8579 into rust-lang:master Jun 29, 2017
@zackmdavis zackmdavis deleted the once_again_we_heard_you_the_first_time branch January 13, 2018 07:43
@zackmdavis zackmdavis mentioned this pull request Apr 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zackmdavis @arielb1 @eddyb @bors @nikomatsakis