Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lint for unused macros #41907

Merged
merged 8 commits into from
May 17, 2017
Merged

Add lint for unused macros #41907

merged 8 commits into from
May 17, 2017

Commits on May 13, 2017

  1. Add lint for unused macros

    @est31
    est31 committed May 13, 2017
    Configuration menu
    Copy the full SHA
    df188b8 View commit details
    Browse the repository at this point in the history

  2. Extend the libsyntax visitor to work over macro defs

    @est31
    est31 committed May 13, 2017
    Configuration menu
    Copy the full SHA
    db82c57 View commit details
    Browse the repository at this point in the history

  3. Support #[allow] etc logic on a per macro level 

    This commit extends the current unused macro linter
to support directives like #[allow(unused_macros)]
or #[deny(unused_macros)] directly next to the macro
definition, or in one of the modules the macro is
inside. Before, we only supported such directives
at a per crate level, due to the crate's NodeId
being passed to session.add_lint.

We also had to implement handling of the macro's
NodeId in the lint visitor.
    @est31
    est31 committed May 13, 2017
    Configuration menu
    Copy the full SHA
    d14d194 View commit details
    Browse the repository at this point in the history

  4. libcore: #[allow] some unused macros

    @est31
    est31 committed May 13, 2017
    Configuration menu
    Copy the full SHA
    ba0601d View commit details
    Browse the repository at this point in the history

  5. Add test, and fix the other tests

    @est31
    est31 committed May 13, 2017
    Configuration menu
    Copy the full SHA
    b36d23c View commit details
    Browse the repository at this point in the history

Commits on May 14, 2017

  1. librustc_incremental: remove unused macro in test case

    @est31
    est31 committed May 14, 2017
    Configuration menu
    Copy the full SHA
    0d0cb27 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2017

  1. Address review comments

    @est31
    est31 committed May 15, 2017
    Configuration menu
    Copy the full SHA
    25b7f10 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2017

  1. put option_try macro def under #[cfg(unix)]

    @est31
    est31 committed May 16, 2017
    Configuration menu
    Copy the full SHA
    6dbd706 View commit details
    Browse the repository at this point in the history