Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macros: fix const expression invocations #40272

Merged
merged 1 commit into from
Mar 6, 2017
Merged

macros: fix const expression invocations #40272

merged 1 commit into from
Mar 6, 2017

Conversation

jseyfried
Copy link
Contributor

Fixes #40136.
r? @nrc

@jseyfried jseyfried mentioned this pull request Mar 5, 2017
Closed
@petrochenkov
Copy link
Contributor

Missing main in the run-pass test.

@jseyfried jseyfried force-pushed the fix_const_macro_invocations branch from 095bcea to 9fe7d3f Compare March 5, 2017 23:58
@jseyfried
Copy link
Contributor Author

@petrochenkov Thanks -- fixed.

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Mar 6, 2017

📌 Commit 9fe7d3f has been approved by petrochenkov

@bors
Copy link
Contributor

bors commented Mar 6, 2017

⌛ Testing commit 9fe7d3f with merge 1c34389...

@bors
Copy link
Contributor

bors commented Mar 6, 2017

💔 Test failed - status-appveyor

@jseyfried
Copy link
Contributor Author

@bors retry

@bors
Copy link
Contributor

bors commented Mar 6, 2017

⌛ Testing commit 9fe7d3f with merge 0cc7037...

@bors
Copy link
Contributor

bors commented Mar 6, 2017

💔 Test failed - status-appveyor

@jseyfried
Copy link
Contributor Author

@bors retry

@bors
Copy link
Contributor

bors commented Mar 6, 2017

⌛ Testing commit 9fe7d3f with merge 344dc3f...

@bors
Copy link
Contributor

bors commented Mar 6, 2017

💔 Test failed - status-travis

@petrochenkov
Copy link
Contributor

@bors retry

@bors
Copy link
Contributor

bors commented Mar 6, 2017

⌛ Testing commit 9fe7d3f with merge 2777b47...

@bors
Copy link
Contributor

bors commented Mar 6, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

alexcrichton commented Mar 6, 2017 via email

@bors
Copy link
Contributor

bors commented Mar 6, 2017

⌛ Testing commit 9fe7d3f with merge b04ebef...

bors added a commit that referenced this pull request Mar 6, 2017
@bors
Auto merge of #40272 - jseyfried:fix_const_macro_invocations, r=petro…
b04ebef 
…chenkov

macros: fix const expression invocations

Fixes #40136.
r? @nrc
@bors
Copy link
Contributor

bors commented Mar 6, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing b04ebef to master...

@bors bors merged commit 9fe7d3f into rust-lang:master Mar 6, 2017
@jseyfried jseyfried added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 7, 2017
@jseyfried jseyfried deleted the fix_const_macro_invocations branch March 7, 2017 06:24
@jseyfried
Copy link
Contributor Author

Nominated for beta: fixes a minor stable-to-stable regression (error to ICE), very simple PR.

@TimNN TimNN mentioned this pull request Mar 9, 2017
Closed
@brson brson added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 9, 2017
@brson brson mentioned this pull request Mar 9, 2017
Merged
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 9, 2017
bors added a commit that referenced this pull request Mar 9, 2017
@bors
Auto merge of #40401 - brson:beta-next, r=alexcrichton
94dca9a 
Beta next

- #40285
- #40272
- #40064
- #39835
- #40398

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nrc nrc

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jseyfried @petrochenkov @bors @alexcrichton @brson @nrc