Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustbuild: Retry downloads by default #40060

Merged
merged 1 commit into from
Feb 25, 2017
Merged

rustbuild: Retry downloads by default #40060

merged 1 commit into from
Feb 25, 2017

Conversation

alexcrichton
Copy link
Member

Don't rely on curl's --retry, it appears to not work for some errors like SSL
errors.

@alexcrichton
rustbuild: Retry downloads by default
30b0ed0 
Don't rely on curl's --retry, it appears to not work for some errors like SSL
errors.
@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@aturon
Copy link
Member

aturon commented Feb 23, 2017

@bors: r+

@bors
Copy link
Contributor

bors commented Feb 23, 2017

📌 Commit 30b0ed0 has been approved by aturon

@frewsxcv
Copy link
Member

This is tangential to your PR, but is there any way to prevent this from happening? https://travis-ci.org/rust-lang/rust/jobs/204633420 It was just stalling for 30 minutes due to, presumably, network issues

@alexcrichton
Copy link
Member Author

Unfortunately not that I know of, that was likely cloning just at a really slow rate

@frewsxcv
Copy link
Member

@bors p=15

@frewsxcv
Copy link
Member

@bors p=7

@bors
Copy link
Contributor

bors commented Feb 24, 2017

⌛ Testing commit 30b0ed0 with merge ec9eca5...

@bors
Copy link
Contributor

bors commented Feb 24, 2017

💔 Test failed - status-travis

@frewsxcv
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Feb 24, 2017

⌛ Testing commit 30b0ed0 with merge a3b807d...

@bors
Copy link
Contributor

bors commented Feb 24, 2017

💔 Test failed - status-travis

@frewsxcv
Copy link
Member

@bors retry

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 24, 2017
@frewsxcv
Rollup merge of rust-lang#40060 - alexcrichton:retry-downloads, r=aturon
1166995 
rustbuild: Retry downloads by default

Don't rely on curl's --retry, it appears to not work for some errors like SSL
errors.
@frewsxcv frewsxcv mentioned this pull request Feb 24, 2017
Closed
bors added a commit that referenced this pull request Feb 24, 2017
@bors
Auto merge of #40080 - frewsxcv:rollup, r=frewsxcv
c9d3749 
Rollup of 17 pull requests

- Successful merges: #39777, #39815, #39845, #39886, #39892, #39903, #39905, #39914, #39927, #39940, #40010, #40030, #40048, #40050, #40052, #40060, #40071
- Failed merges:
@bors
Copy link
Contributor

bors commented Feb 24, 2017

⌛ Testing commit 30b0ed0 with merge 14061ce...

bors added a commit that referenced this pull request Feb 24, 2017
@bors
Auto merge of #40060 - alexcrichton:retry-downloads, r=aturon
14061ce 
rustbuild: Retry downloads by default

Don't rely on curl's --retry, it appears to not work for some errors like SSL
errors.
@arielb1
Copy link
Contributor

arielb1 commented Feb 24, 2017

Note: both travis failures are #39003.

@bors
Copy link
Contributor

bors commented Feb 24, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member Author

alexcrichton commented Feb 24, 2017 via email

@bors
Copy link
Contributor

bors commented Feb 25, 2017

⌛ Testing commit 30b0ed0 with merge e78aa5d...

bors added a commit that referenced this pull request Feb 25, 2017
@bors
Auto merge of #40060 - alexcrichton:retry-downloads, r=aturon
e78aa5d 
rustbuild: Retry downloads by default

Don't rely on curl's --retry, it appears to not work for some errors like SSL
errors.
@bors
Copy link
Contributor

bors commented Feb 25, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: aturon
Pushing e78aa5d to master...

@bors bors merged commit 30b0ed0 into rust-lang:master Feb 25, 2017
@alexcrichton alexcrichton deleted the retry-downloads branch March 8, 2017 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexcrichton @rust-highfive @aturon @bors @frewsxcv @arielb1