Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create the Unstable Book #39866

Merged
merged 6 commits into from
Feb 23, 2017
Merged

Create the Unstable Book #39866

merged 6 commits into from
Feb 23, 2017

Conversation

steveklabnik
Copy link
Member

@steveklabnik steveklabnik commented Feb 15, 2017 •
edited
Loading

Part of #39588

This isn't done yet. To do:

  • import the nightly book contents here
  • possibly write some more chapters

This will not be done before it lands; that's part of the whole unstable thing.

@rust-highfive
Copy link
Collaborator

@steveklabnik: no appropriate reviewer found, use r? to override

@steveklabnik steveklabnik mentioned this pull request Feb 15, 2017
Closed
10 tasks
@steveklabnik
Copy link
Member Author

Okay, this is good to go. I think we should merge and then write more chapters; it's a neat way for people to contribute!

I'd like to hear @rust-lang/docs 's thoughts on this.

@steveklabnik steveklabnik force-pushed the unstable-book branch 2 times, most recently from 0c87a0e to cc36ae0 Compare February 20, 2017 13:12
@steveklabnik
Copy link
Member Author

Blocked on #39976

@steveklabnik
Copy link
Member Author

This and #39855 are inter-twined since they reference each other. Let's land #39855 first.

@alexcrichton
Copy link
Member

@steveklabnik r=me on the technicals w/ rustbuild and such, I'll leave it up to you to run by @rust-lang/docs on the content

@steveklabnik
Copy link
Member Author

steveklabnik commented Feb 21, 2017 •
edited
Loading

Now that #39855 is r+'d I've rebased this on top of it, and fixed things up.

r? @frewsxcv (you only need to review the last 6 commits, that is, 7e4b7a0 and forward. the rest are from the other PR, and should disappear once it merges)

@steveklabnik
Copy link
Member Author

steveklabnik commented Feb 22, 2017 •
edited
Loading

Yay! the preceding one passed. I've rebased those commits out.

There seems to be no opposition to landing this, and I'd like to before it gets out of date, so

@bors: r=alexcrichton p=1

(This only bumps it up one place in the queue but still)

@bors
Copy link
Contributor

bors commented Feb 22, 2017

📌 Commit 06e311b has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Feb 22, 2017

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Feb 22, 2017

📌 Commit 06e311b has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Feb 22, 2017

⌛ Testing commit 06e311b with merge 1dff7f1...

@bors
Copy link
Contributor

bors commented Feb 22, 2017

💔 Test failed - status-travis

@steveklabnik
Copy link
Member Author

steveklabnik commented Feb 22, 2017 •
edited
Loading

@bors: retry

spurious failure https://travis-ci.org/rust-lang/rust/jobs/204048041#L4348 etc

@bors
Copy link
Contributor

bors commented Feb 22, 2017

⌛ Testing commit 06e311b with merge 2ef7eb0...

bors added a commit that referenced this pull request Feb 22, 2017
@bors
Auto merge of #39866 - steveklabnik:unstable-book, r=alexcrichton
2ef7eb0 
Create the Unstable Book

Part of #39588

This isn't done yet. To do:

- [x] import the nightly book contents here
- [ ] possibly write some more chapters

This will _not_ be done before it lands; that's part of the whole unstable thing.
@alexcrichton
Copy link
Member

@bors: retry

appveyor somehow missed this PR?

@bors
Copy link
Contributor

bors commented Feb 22, 2017

⌛ Testing commit 06e311b with merge 54b5f03...

@bors
Copy link
Contributor

bors commented Feb 22, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

alexcrichton commented Feb 22, 2017 via email

@steveklabnik
Copy link
Member Author

@bors: p=11

this should have landed by now due to spurious failures but it still hasn't, I am unlikely to be able to monitor it tomorrow

@bors
Copy link
Contributor

bors commented Feb 22, 2017

⌛ Testing commit 06e311b with merge bfe4597...

bors added a commit that referenced this pull request Feb 22, 2017
@bors
Auto merge of #39866 - steveklabnik:unstable-book, r=alexcrichton
bfe4597 
Create the Unstable Book

Part of #39588

This isn't done yet. To do:

- [x] import the nightly book contents here
- [ ] possibly write some more chapters

This will _not_ be done before it lands; that's part of the whole unstable thing.
@bors
Copy link
Contributor

bors commented Feb 23, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing bfe4597 to master...

@bors bors merged commit 06e311b into rust-lang:master Feb 23, 2017
@steveklabnik steveklabnik deleted the unstable-book branch February 23, 2017 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frewsxcv frewsxcv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@steveklabnik @rust-highfive @alexcrichton @bors @frewsxcv