Add prefix to config.toml #38388
Merged
Add prefix to config.toml #38388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
Thanks! This may actually be a good time to start a new section of |
|
@alexcrichton Sounds good. |
frewsxcv
reviewed
Dec 15, 2016
| @@ -70,6 +70,9 @@ | |||
| # specified, use this rustc binary instead as the stage0 snapshot compiler. | |||
| #rustc = "/path/to/bin/rustc" | |||
|
|
|||
| # Instead of installing installing to /usr/local, install to this path instead. | |||
There was a problem hiding this comment.
Thanks, I fixed it
jackpot51
force-pushed
the
config_toml_prefix
branch
from
5660f6c
to
58b94bd
Compare
|
@alexcrichton I have made the change, adding an |
|
Looks good to me! It appears tidy has a problem though? |
|
I will fix the tidy issue - thanks |
|
@bors: r+ |
|
📌 Commit 228e495 has been approved by |
|
Thanks @alexcrichton ! |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 20, 2016
…crichton Add prefix to config.toml This allows `rustbuild` to be used to install to a prefix. ```toml [build] prefix = "/path/to/install" ``` For example, the following `config.toml` will cause `x.py dist --install` to install to `/path/to/install`
bors
added a commit
that referenced
this pull request
Dec 20, 2016
Rollup of 29 pull requests - Successful merges: #37761, #38006, #38131, #38150, #38158, #38171, #38208, #38215, #38236, #38245, #38289, #38302, #38315, #38346, #38388, #38395, #38398, #38418, #38432, #38451, #38463, #38468, #38470, #38471, #38472, #38478, #38486, #38493, #38498 - Failed merges: #38271, #38483
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
rustbuildto be used to install to a prefix.For example, the following
config.tomlwill causex.py dist --installto install to/path/to/install