Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix $crate-related regressions #37361

Merged
merged 3 commits into from
Oct 26, 2016

Conversation

jseyfried
Copy link
Contributor

Fixes #37345, fixes #37357, fixes #37352, and improves the unused_extern_crates lint.
r? @nrc

@petrochenkov
Copy link
Contributor

FWIW, local use $crate; is very similar to use::super; importing the crate root from #37156.
I'd say both should be legal and import a special unusable name, and use $crate as x;/use::super as x; should be legal and declare name x referring to the root module.

@nrc
Copy link
Member

nrc commented Oct 25, 2016

@bors r+

Could you file a tracking issue for use $crate; please?

@bors
Copy link
Contributor

bors commented Oct 25, 2016

📌 Commit 9106d21 has been approved by nrc

@jseyfried
Copy link
Contributor Author

cc #37390

@bors
Copy link
Contributor

bors commented Oct 25, 2016

☔ The latest upstream changes (presumably #37292) made this pull request unmergeable. Please resolve the merge conflicts.

@jseyfried
Copy link
Contributor Author

@bors r=nrc

@bors
Copy link
Contributor

bors commented Oct 25, 2016

📌 Commit 0d30325 has been approved by nrc

@jseyfried
Copy link
Contributor Author

@bors p=1 (this is causing a lot of regressions in practice)

@bors
Copy link
Contributor

bors commented Oct 26, 2016

⌛ Testing commit 0d30325 with merge a7557e7...

bors added a commit that referenced this pull request Oct 26, 2016
Fix `$crate`-related regressions

Fixes #37345, fixes #37357, fixes #37352, and improves the `unused_extern_crates` lint.
r? @nrc
@bors bors merged commit 0d30325 into rust-lang:master Oct 26, 2016
@jseyfried jseyfried deleted the fix_crate_var_regressions branch October 26, 2016 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants