normalize types every time HR regions are erased #37129
Conversation
arielb1
added
the
beta-nominated
|
@bors r+ |
|
📌 Commit e8cccdb has been approved by |
|
⌛ Testing commit e8cccdb with merge cc76d49... |
|
💔 Test failed - auto-linux-cross-opt |
This reverts commit 7badc32.
Associated type normalization is inhibited by higher-ranked regions. Therefore, every time we erase them, we must re-normalize. I was meaning to introduce this change some time ago, but we used to erase regions in generic context, which broke this terribly (because you can't always normalize in a generic context). That seems to be gone now. Ensure this by having a `erase_late_bound_regions_and_normalize` function. Fixes rust-lang#37109 (the missing call was in mir::block).
arielb1
force-pushed
the
erased-normal
branch
from
e8cccdb
to
ee338c3
Compare
|
@bors r=eddyb |
|
📌 Commit ee338c3 has been approved by |
|
@bors p=1 |
|
⌛ Testing commit ee338c3 with merge 9872eab... |
|
💔 Test failed - auto-win-gnu-64-opt |
|
Looks like |
|
But the test passes on travis @bors retry |
|
⌛ Testing commit ee338c3 with merge 6572a46... |
normalize types every time HR regions are erased Associated type normalization is inhibited by higher-ranked regions. Therefore, every time we erase them, we must re-normalize. I was meaning to introduce this change some time ago, but we used to erase regions in generic context, which broke this terribly (because you can't always normalize in a generic context). That seems to be gone now. Ensure this by having a `erase_late_bound_regions_and_normalize` function. Fixes #37109 (the missing call was in mir::block). r? @eddyb
|
💔 Test failed - auto-mac-64-opt-rustbuild |
|
That test runs at the same speed on stage0/stage2 on my local machine. |
|
@bors: retry On Sun, Oct 16, 2016 at 6:25 AM, arielb1 notifications@github.com wrote:
|
nikomatsakis
added
the
beta-accepted
|
Marking as beta-accepted. Low-risk (running normalize can't really cause bugs), regression. cc @rust-lang/compiler |
brson
removed
the
beta-nominated
Associated type normalization is inhibited by higher-ranked regions.
Therefore, every time we erase them, we must re-normalize.
I was meaning to introduce this change some time ago, but we used
to erase regions in generic context, which broke this terribly (because
you can't always normalize in a generic context). That seems to be gone
now.
Ensure this by having a
erase_late_bound_regions_and_normalizefunction.
Fixes #37109 (the missing call was in mir::block).
r? @eddyb