Rollup of 27 pull requests

[eddyb]

• Successful merges: typeck: if a private field exists, also check for a public method #33342, Add error description for E0455 #33393, Add error explanations for E0374, E0375, E0376 on issue #32777 #33415, Add detailed error explanation for E0505 #33475, Tighten span for E0063 #33517, Add E0500 error explanation #33533, Simplify text #33534, Fix typo in std::sync::Once documentation #33565, Cleanup formatting and wording for std::env::temp_dir docs. #33580, Add more details and examples in error codes #33584, Add compile-fail tests for error codes #33585, add UI testing framework #33588, update "reason" for fnbox feature gate #33590, Use the correct word in the explanation #33591, Improve derived implementations for enums with lots of fieldless variants #33593, doc: Fix comment in std::string::String example code #33598, rustdoc: Fix missing type parameters on impls #33600, Save metadata even with -Z no-trans (e.g. for multi-crate cargo check). #33602, doc: to_string not needed since we gots coercion #33603, doc: line these comments up #33604, doc: use less awkward and less confusing language #33605, Some simple improvements to MIR pretty printing #33607, gdb Pretty Print: generic encoded was failing on reference/pointer types #33612, mir: always allow &mut [...] in static mut regardless of the array length. #33620, doc: this statement does not have an effect #33633, doc: improve output #33634, doc: 'tis the lang, not the reptile #33635
• Failed merges: update tracking issue for once_poison #33578

[rust-highfive]

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

[eddyb]

@bors r+ p=123

[bors]

📌 Commit 72f0bfe has been approved by eddyb

[bors]

⌛ Testing commit 72f0bfe with merge bef9056...

[bors]

💔 Test failed - auto-mac-64-opt-rustbuild

[arielb1]

/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt-rustbuild/build/src/librustc_const_math/lib.rs:31:14: 31:34 error: can't find crate for `syntax` [E0463]
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt-rustbuild/build/src/librustc_const_math/lib.rs:31 #[macro_use] extern crate syntax;
                                                                                                                        ^~~~~~~~~~~~~~~~~~~~
error: aborting due to previous error
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt-rustbuild/build/src/libsyntax_ext/lib.rs:28:1: 28:21 error: can't find crate for `syntax` [E0463]
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt-rustbuild/build/src/libsyntax_ext/lib.rs:28 extern crate syntax;
                                                                                                     ^~~~~~~~~~~~~~~~~~~~
error: aborting due to previous error
Build failed, waiting for other jobs to finish...
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt-rustbuild/build/src/librustc_back/lib.rs:44:1: 44:21 error: can't find crate for `syntax` [E0463]
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt-rustbuild/build/src/librustc_back/lib.rs:44 extern crate syntax;
                                                                                                     ^~~~~~~~~~~~~~~~~~~~
error: aborting due to previous error

?

@bors retry

[eddyb]

@arielb1 Yeah I have no explanation either, stage0 compiles but stage1 doesn't and they have the same Cargo.toml's and whatnot. No change in this rollup seems to actually affect any of that code and I can't see how my metadata change could do this.

[eddyb]

@bors force

[bors]

⌛ Testing commit 72f0bfe with merge 89f8e6a...

[bors]

💔 Test failed - auto-mac-64-opt-rustbuild

[eddyb]

cc @alexcrichton because I'm dumbfounded again.

[alexcrichton]

Was Cargo.toml forgotten to be updated? (sorry on a phone hard to check)

On Saturday, May 14, 2016, Eduard-Mihai Burtescu notifications@github.com
wrote:

cc @alexcrichton https://github.com/alexcrichton because I'm
dumbfounded again.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#33643 (comment)

[eddyb]

@alexcrichton I wish, but I can't find anything like that in the combined diff of the rollup.

[alexcrichton]

Looks like the cdylib PR failed for the same reason, I'd back that out and I can investigate it locally

[eddyb]

@alexcrichton Bummer, since I have the version of that from a couple days ago in my item_symbols removal PR. Let me know if you figure out what's wrong with it.

[eddyb]

Whatever, let's get something small going.

@bors r+

[bors]

📌 Commit ffbfbe4 has been approved by eddyb

[bors]

⌛ Testing commit ffbfbe4 with merge bb39c49...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-32cross-opt, auto-linux-64-cargotest, auto-linux-64-cross-armhf, auto-linux-64-cross-armsf, auto-linux-64-cross-freebsd, auto-linux-64-cross-netbsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-cross-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild