Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: format! may or may not handle streams in future #33606

Merged
merged 1 commit into from
Jun 1, 2016
Merged

doc: format! may or may not handle streams in future #33606

merged 1 commit into from
Jun 1, 2016

Conversation

tshepang
Copy link
Member

No need to talk about that here

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@mhristache
Copy link

I think you removed a bit too much text as it's important info that format! returns a String.

@brson
Copy link
Contributor

brson commented May 13, 2016

If you are removing references to streams please remove the one from the first para too: "This macro is implemented in the compiler to emit calls to this module in order to format arguments at runtime into strings and streams."

@maximih that first paragraph also mentions that format returns strings so maybe is sufficient. @tshepang maybe this sentence can be changed to be more clear about creating String.

If we're removing irrelevant info, the detail that format! is implemented in the compiler is hardly the first thing I would call out in the docs.

@birkenfeld
Copy link
Contributor

Isn't write!()/writeln!() what's used to write to streams? In that case it could just be linked to.

@tshepang
Copy link
Member Author

@brson I don't understand this:

If we're removing irrelevant info, the detail that format! is implemented in the compiler is hardly the first thing I would call out in the docs.

@brson
Copy link
Contributor

brson commented May 31, 2016

@tshepang The second sentence of the description of format! begins with "This macro is implemented in the compiler". I was just saying that that bit of information is irrelevant to users.

@brson
Copy link
Contributor

brson commented May 31, 2016

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 31, 2016

📌 Commit 5c34892 has been approved by brson

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 1, 2016
doc: format! may or may not handle streams in future

No need to talk about that here
bors added a commit that referenced this pull request Jun 1, 2016
Rollup of 11 pull requests

- Successful merges: #33385, #33606, #33841, #33892, #33896, #33915, #33921, #33967, #33970, #33973, #33977
- Failed merges:
@bors bors merged commit 5c34892 into rust-lang:master Jun 1, 2016
@tshepang tshepang deleted the future-talk branch June 1, 2016 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants