Fix import resolution bug

[jseyfried]

This fixes #32222, which was introduced in #31726.

[jseyfried]

Whenever decrement_outstanding_references_for caused an indeterminate NameResolution to become a success (by no longer blocking a glob import), the binding was defined in all known glob importers of its containing module.

This use of decrement_outstanding_references_for was incorrect since it would only make the resolution successful temporarily (after which the resolution is reverted to its previous state). It caused a binding to be defined in all known glob importers each time the resolution became temporarily successful, leading to incorrect duplicate errors (and other privacy-related bugs).

[jseyfried]

r? @alexcrichton

[alexcrichton]

@bors: r+ d102014

Thanks for the quick fix @jseyfried! Does this affect beta as well do you know? If so this would probably be a good candidate for a backport.

[bors]

⌛ Testing commit d102014 with merge d5880ff...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

[jseyfried]

@alexcrichton this doesn't affect beta.