Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #29533 #29535

Merged
merged 1 commit into from Nov 3, 2015
Merged

Fix #29533 #29535

merged 1 commit into from Nov 3, 2015

Conversation

ghost
Copy link

@ghost ghost commented Nov 3, 2015

This basically just inlines the fatal! macro from BurntSushi's blog post.

cc @steveklabnik

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

So, this is good, but why not just panic!? It'd be a little bit simpler, and almost be the same thing.

@ghost
Copy link
Author

ghost commented Nov 3, 2015

Sure, avoiding unwinding doesn't seem necessary here, so I'll change this to panic! instead.

This replaces usage of the (missing) `fatal!` macro with `panic!`.
@ghost
Copy link
Author

ghost commented Nov 3, 2015

@steveklabnik should be okay now

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Nov 3, 2015

📌 Commit d9df16b has been approved by steveklabnik

bors added a commit that referenced this pull request Nov 3, 2015
@bors
Copy link
Contributor

bors commented Nov 3, 2015

⌛ Testing commit d9df16b with merge f18c905...

@steveklabnik
Copy link
Member

Great! Thanks so much :)

@ghost
Copy link
Author

ghost commented Nov 3, 2015

No problem :-)

@bors bors merged commit d9df16b into rust-lang:master Nov 3, 2015
@ghost ghost deleted the patch-1 branch November 3, 2015 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants