Clarify Windows gcc setup instructions. #29509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -68,7 +68,7 @@ Read ["Installing Rust"] from [The Book]. | |||
| # Update package mirrors (may be needed if you have a fresh install of MSYS2) | |||
| $ pacman -Sy pacman-mirrors | |||
|
|
|||
| # Choose one based on platform: | |||
| # Choose one based on platform: (+++ see the note below +++) | |||
There was a problem hiding this comment.
Perhaps this should be a note in bold below the header? The pluses look weird.
There was a problem hiding this comment.
It's in a code block, normal formatting doesn't work there.
There was a problem hiding this comment.
Ah. Could you still move it to another line and use stars to make it stand out?
|
⌛ Testing commit 363deb0 with merge 5b87225... |
bors
added a commit
that referenced
this pull request
Nov 3, 2015
The current readme provides critical information about gcc versions too late in the flow. r? @steveklabnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current readme provides critical information about gcc versions too late in the flow.
r? @steveklabnik