Doc backport #24814
Merged
Doc backport #24814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only backporting the style portion, as changing the test suite is needless churn, and the book/reference are getting their own imports at the end.
In 8f5b5f9, `default::Default` was added to the prelude, so these imports are no longer necessary.
Without the `box` keyword, one of these two reasons is not correct, so let's just eliminate this section and elaborate on the reason for the legit use case inline. Fixes rust-lang#24511
As far as I can tell, this conversion to integer to floating point does not need to happen and is beside the point
- rust-lang#1237 is closed - `libgcc` is now statically linked: rust-lang#17471
|
@bors: try |
|
🔒 Merge conflict |
|
r? @gankro (rust_highfive has picked a reviewer for you, use r? to override) |
|
Ahh i guess try only works to master. |
|
I'm gonna run a test locally before merging. |
|
Presumably I don't actually need to review anything for this kind of PR? |
|
@gankro yeah, I already assigned it to myself. ❤️ |
|
Passed all tests locally. 🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports to beta all non-reference, non-TRPL documentation commits made since we forked. At least, up until the two PRs that are open today.
Result::unwrap()#24606Only one had two commits, hence 18 PRs and 19 commits.