Rollup of 14 pull requests #24648
Merged
Rollup of 14 pull requests #24648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
Apr 21, 2015
steveklabnik
commented
- Successful merges: Suppress improper_ctypes warnings when compiling liballoc with external_features #24514, Add common macros to TRPL #24516, More TRPl editing #24571, Remove feature gated examples from the reference #24577, Simplify alloc::arc::Arc example in doc-comment #24625, Make iterator struct docs more consistent. #24627, remove bad example from PartialEq docs #24628, Clean up Box documentation. #24629, Fix small typo in TRPL intro #24630, TRPL: unsafe -> raw pointers #24631, TRPL: casting #24632, lint: explain the non-obvious need for a negative test #24642, TRPL: if let #24643, Update reference to old_io in fmt docs #24647
- Failed merges: Refocus unsafe code chapter on unsafe itself. #24640
As far as I can tell, this conversion to integer to floating point does not need to happen and is beside the point
Now that we're not doing the guessing game, a lot of this is irrelevant.
Partially addresses rust-lang#24388
We want to talk about how to pattern match on structs, so let's bump it back one.
It's a trait implementation, so we need traits first.
It's a language feature, so it belongs here.
Let's talk about generics first, since we use traits to bound them in funtions. Partially addresses rust-lang#24325 Fixes rust-lang#24271
Without the `box` keyword, one of these two reasons is not correct, so let's just eliminate this section and elaborate on the reason for the legit use case inline. Fixes rust-lang#24511
Due to documenting `transmute`, addresses part of rust-lang#12905
The slice patterns example was nice, so let's put it with the other slice pattern feature gate documentation. Fixes rust-lang#24573
Many unsafe features are now in the unstable section, so this section is really just about raw pointers now. That also makes sense for its place in the TOC. This addresses part of rust-lang#12905.
and while let
…=alexcrichton When `liballoc` is compiled with `--cfg feature=\"external_features\"`, several `improper_ctypes` warnings are generated. Since these warnings are harmless, I have added a directive to suppress them.
A bunch of chapters, fixes an issue or two as well. r? @alexcrichton
As far as I can tell, this conversion to integer to floating point does not need to happen and is beside the point
Fixes rust-lang#24173 These docs could all use examples, so for now, let's just remove the bad one, and when I go over this whole module I'll put in better ones.
Without the `box` keyword, one of these two reasons is not correct, so let's just eliminate this section and elaborate on the reason for the legit use case inline. Fixes rust-lang#24511
…ichton Many unsafe features are now in the unstable section, so this section is really just about raw pointers now. That also makes sense for its place in the TOC. This addresses part of rust-lang#12905.
…richton Due to documenting `transmute`, addresses part of rust-lang#12905
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
Fixed up #24640 so it gets in too. |
|
@bors: r+ p=100 force |
|
📌 Commit 9ddcc38 has been approved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.