Prefer ObjectCandidate to ImplCandidate if both apply #24056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
force-pushed
the
issue-23853-crates-io
branch
from
5ca89f3
to
dfbc4c6
Compare
|
So many fixed issues! Thanks @nikomatsakis! (there's a tidy error) |
|
r=me, p=1 after tidy fix |
`Trait`, prefer the object. Also give a nice error for attempts to manually `impl Trait for Trait`, since they will be ineffectual. Fixes rust-lang#24015. Fixes rust-lang#24051. Fixes rust-lang#24037. Fixes rust-lang#23853. Fixes rust-lang#21942. cc rust-lang#21756.
nikomatsakis
force-pushed
the
issue-23853-crates-io
branch
from
dfbc4c6
to
0d56699
Compare
|
📌 Commit 0d56699 has been approved by |
bors
added a commit
that referenced
this pull request
Apr 6, 2015
If we find a blanket impl for `Trait` but we're matching on an object `Trait`, prefer the object (I think we could perhaps go either way, but this seems safer). Also give a nice error for attempts to manually `impl Trait for Trait`, since they will be ineffectual. This fixes the problems around ambiguity ICEs relating to `Any` and `MarkerTrait` that were cropping up all over the place. There may still be similar ICEs reported in #21756 that this PR does not address. Fixes #24015. Fixes #24051. Fixes #24037. Fixes #23853. Fixes #21942. cc #21756. cc @alexcrichton (this fixes crates.io) r? @aturon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we find a blanket impl for
Traitbut we're matching on an objectTrait, prefer the object (I think we could perhaps go either way, but this seems safer). Also give a nice error for attempts to manuallyimpl Trait for Trait, since they will be ineffectual.This fixes the problems around ambiguity ICEs relating to
AnyandMarkerTraitthat were cropping up all over the place. There may still be similar ICEs reported in #21756 that this PR does not address.Fixes #24015.
Fixes #24051.
Fixes #24037.
Fixes #23853.
Fixes #21942.
cc #21756.
cc @alexcrichton (this fixes crates.io)
r? @aturon