Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up build warnings about use of [] #22824

Closed
wants to merge 1 commit into from

Conversation

bossmc
Copy link
Contributor

@bossmc bossmc commented Feb 26, 2015

Simple PR to fix some build warnings on a clean clone of master.

/home/ubuntu/src/rust/src/librustc/middle/astconv_util.rs:71:51: 71:53 warning: obsolete syntax: []
/home/ubuntu/src/rust/src/librustc/middle/astconv_util.rs:71             Some(prim_ty_to_ty(tcx, &path.segments[], nty))
                                                                                                               ^~
note: write `[..]` instead
...
/home/ubuntu/src/rust/src/librustc_resolve/lib.rs:2988:53: 2988:55 warning: obsolete syntax: []
/home/ubuntu/src/rust/src/librustc_resolve/lib.rs:2988             self.resolve_error(trait_path.span, &msg[]);
                                                                                                           ^~
note: write `[..]` instead

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@alexcrichton
Copy link
Member

@bors: r+ d9bdc43 rollup

@alexcrichton
Copy link
Member

Thanks!

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Feb 26, 2015
Simple PR to fix some build warnings on a clean clone of master.

```
/home/ubuntu/src/rust/src/librustc/middle/astconv_util.rs:71:51: 71:53 warning: obsolete syntax: []
/home/ubuntu/src/rust/src/librustc/middle/astconv_util.rs:71             Some(prim_ty_to_ty(tcx, &path.segments[], nty))
                                                                                                               ^~
note: write `[..]` instead
...
/home/ubuntu/src/rust/src/librustc_resolve/lib.rs:2988:53: 2988:55 warning: obsolete syntax: []
/home/ubuntu/src/rust/src/librustc_resolve/lib.rs:2988             self.resolve_error(trait_path.span, &msg[]);
                                                                                                           ^~
note: write `[..]` instead
```
@Manishearth
Copy link
Member

This is superseded by #22835, I think.

@bossmc
Copy link
Contributor Author

bossmc commented Feb 27, 2015

@Manishearth Agreed (though that PR's changes are slightly different in a few places). I'm happy for this to be closed if that change is merged.

@bors
Copy link
Contributor

bors commented Feb 28, 2015

☔ The latest upstream changes (presumably #22860) made this pull request unmergeable. Please resolve the merge conflicts.

@emberian emberian closed this Feb 28, 2015
@bossmc bossmc deleted the build-warnings branch June 16, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants