Obsolete the closure kind syntax #21843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎯 |
|
r=me, nice work! For posterity, the offending FIXMEs were all inserted in this commit: 2c91b5e9199b5b8631a74ac3d50359df54d745b7 |
|
Regarding the FIXMEs, those were known -- that is, there is still a bit of remaining work as described in #21805. |
|
Should I change the FIXMEs to point to the issue for @nikomatsakis's follow-up work (is there one?), or should I remove them? |
|
Updated |
japaric
changed the title
|&:| {} -> || {}
|
⌛ Testing commit 92f11e9 with merge 8b55fa7... |
|
💔 Test failed - auto-linux-64-opt |
|
@bors: retry (can't reproduce failure locally) |
bors
added a commit
that referenced
this pull request
Feb 5, 2015
This needs a snapshot that includes #21805 before it can be merged. There are some places where type inference regressed after I removed the annotations (see `FIXME`s). cc @nikomatsakis. r? @eddyb or anyone (I'll remove the `FIXME`s before merging, as they are only intended to point out regressions)
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 10, 2015
…eklabnik Based off rust-lang#21843, it looks like the syntax in the Closures guide is outdated.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Feb 10, 2015
Based off rust-lang#21843, it looks like the syntax in the Closures guide is outdated.
Merged
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 28, 2015
This is leftover from rust-lang#21843 If you still have `|&:| {}` closures in your code, simply remove the `&:` part. [breaking-change]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obsoletes the closure kind syntax (the
&:,&mut::in|&:| {}) as the compiler will now infer the rightFn*trait from the context.To fix your code simply remove the
&:annotations, and let the compiler do the magic.[breaking-change]