rustc: Start "stabilizing" some flags #19900

alexcrichton · 2014-12-16T01:47:14Z

This commit shuffles around some CLI flags of the compiler to some more stable
locations with some renamings. The changes made were:

The -v flag has been repurposes as the "verbose" flag. The version flag has
been renamed to -V.
The -h screen has been split into two parts. Most top-level options (not
all) show with -h, and the remaining options (generally obscure) can be
shown with --help -v which is a "verbose help screen"
The -V flag (version flag now) has lost its argument as it is now requested
with rustc -vV "verbose version".
The --emit option has had its ir and bc variants renamed to llvm-ir
and llvm-bc to emphasize that they are LLVM's IR/bytecode.
The --emit option has grown a new variant, dep-info, which subsumes the
--dep-info CLI argument. The --dep-info flag is now deprecated.
The --parse-only, --no-trans, --no-analysis, and --pretty flags have
moved behind the -Z family of flags.
The --debuginfo and --opt-level flags were moved behind the top-level -C
flag.
The --print-file-name and --print-crate-name flags were moved behind one
global --print flag which now accepts one of crate-name, file-names, or
sysroot. This global --print flag is intended to serve as a mechanism for
learning various metadata about the compiler itself.
The top-level --pretty flag was moved to a number of -Z options.

No warnings are currently enabled to allow tools like Cargo to have time to
migrate to the new flags before spraying warnings to all users.

cc #19051

alexcrichton · 2014-12-16T01:47:21Z

cc @brson, @cmr, @nick29581

sinistersnare · 2014-12-16T01:55:44Z

Not a huge fan of -v being verbose. I think that if people want verbose, they might as well just type --verbose.

emberian · 2014-12-16T02:27:58Z

Looks as discussed, 👍

emberian · 2014-12-16T02:30:53Z

@sinistersnare existing tools aren't consistent about the treatment of -v, -V, --version, and --verbose. This brings us in line with Cargo and some other compilers, including cc.

sinistersnare · 2014-12-16T02:37:57Z

Ah ok :) sounds good, +1 then

mdinger · 2014-12-16T17:49:49Z

Looks like this fixes #17938 and rust-lang/cargo#690

pnkfelix · 2014-12-17T16:16:59Z

cc me

pnkfelix · 2014-12-17T23:49:48Z

The summary claims that --pretty was moved to a number of -Z flags, but not all functionality currently located there was preserved. I suspect everything will pass in this PR as-is, because it does not actually remove "pretty" from the optgroups() result; it just has a comment saying that it and a number of other options are deprecated. (And therefore if I understand correctly, the --pretty flowgraph tests in src/tests/run-make will still run; they are just using an option that has been silently deprecated without a replacement.)

I have proposed -Z unstable-options in PR #19964 as a path towards keeping some getopts-based options that we do not want to be part of the stable interface for our users.

This commit shuffles around some CLI flags of the compiler to some more stable locations with some renamings. The changes made were: * The `-v` flag has been repurposes as the "verbose" flag. The version flag has been renamed to `-V`. * The `-h` screen has been split into two parts. Most top-level options (not all) show with `-h`, and the remaining options (generally obscure) can be shown with `--help -v` which is a "verbose help screen" * The `-V` flag (version flag now) has lost its argument as it is now requested with `rustc -vV` "verbose version". * The `--emit` option has had its `ir` and `bc` variants renamed to `llvm-ir` and `llvm-bc` to emphasize that they are LLVM's IR/bytecode. * The `--emit` option has grown a new variant, `dep-info`, which subsumes the `--dep-info` CLI argument. The `--dep-info` flag is now deprecated. * The `--parse-only`, `--no-trans`, and `--no-analysis` flags have moved behind the `-Z` family of flags. * The `--debuginfo` and `--opt-level` flags were moved behind the top-level `-C` flag. * The `--print-file-name` and `--print-crate-name` flags were moved behind one global `--print` flag which now accepts one of `crate-name`, `file-names`, or `sysroot`. This global `--print` flag is intended to serve as a mechanism for learning various metadata about the compiler itself. No warnings are currently enabled to allow tools like Cargo to have time to migrate to the new flags before spraying warnings to all users.

This commit shuffles around some CLI flags of the compiler to some more stable locations with some renamings. The changes made were: * The `-v` flag has been repurposes as the "verbose" flag. The version flag has been renamed to `-V`. * The `-h` screen has been split into two parts. Most top-level options (not all) show with `-h`, and the remaining options (generally obscure) can be shown with `--help -v` which is a "verbose help screen" * The `-V` flag (version flag now) has lost its argument as it is now requested with `rustc -vV` "verbose version". * The `--emit` option has had its `ir` and `bc` variants renamed to `llvm-ir` and `llvm-bc` to emphasize that they are LLVM's IR/bytecode. * The `--emit` option has grown a new variant, `dep-info`, which subsumes the `--dep-info` CLI argument. The `--dep-info` flag is now deprecated. * The `--parse-only`, `--no-trans`, `--no-analysis`, and `--pretty` flags have moved behind the `-Z` family of flags. * The `--debuginfo` and `--opt-level` flags were moved behind the top-level `-C` flag. * The `--print-file-name` and `--print-crate-name` flags were moved behind one global `--print` flag which now accepts one of `crate-name`, `file-names`, or `sysroot`. This global `--print` flag is intended to serve as a mechanism for learning various metadata about the compiler itself. * The top-level `--pretty` flag was moved to a number of `-Z` options. No warnings are currently enabled to allow tools like Cargo to have time to migrate to the new flags before spraying warnings to all users. cc #19051

pnkfelix · 2014-12-22T14:30:20Z

src/librustc_driver/lib.rs


    let pretty = matches.opt_default("pretty", "normal").map(|a| {
        pretty::parse_pretty(&sess, a.as_slice())
    });
-    match pretty {
+    match pretty.into_iter().next() {


hey @alexcrichton , why did you put in this code that, AFAICT, is the identity function on Option<T> ?

Hm I think I forgot to remove this after some other refactoring in this area, feel free to remove though!

pnkfelix · 2014-12-22T15:02:44Z

@alexcrichton do we have a good place to discuss moving options around (either out of the short groups, or into the unstable-options that I am planning to land today)? In particular, I would imagine --target, --print, --crate-name, and --cfg could all be moved out of the short group.

alexcrichton · 2014-12-22T16:07:44Z

I'm fine with chatting on IRC, I was personally thinking that all of those options would stay at the top-level, but they're certainly flexible!

pnkfelix · 2014-12-22T16:51:32Z

IRC discussion here: https://botbot.me/mozilla/rust-internals/2014-12-22/?msg=28137683&page=7

This pull request updates the rustc manual page to represent post-rust-lang#19900 state of rustc options better. A bit unrelatedly, --help output is changed to fix some issues too: * -g and -O descriptions were changed from deprected flags to the new codegen flags. * dep-info value was moved from crate-type to emit flag. Fixes rust-lang#20111 Fixes rust-lang#20131

This pull request updates the rustc manual page to represent current state of rustc option handling better. Moved the apparently deprecated options (rust-lang#19900) to their own section and added all the new codegen options. A bit unrelatedly, I also updated description of `-O` and `-g` flags to point to the new codegen options rather than old, deprecated ones. Fixes rust-lang#20111.

aturon mentioned this pull request Dec 16, 2014

Stabilization metabug: 1.0-alpha #19260

Closed

pnkfelix mentioned this pull request Dec 17, 2014

Everybody loops pprint; -Z unstable-options #19964

Merged

alexcrichton force-pushed the compiler-flags branch 3 times, most recently from c51860c to 2c23def Compare December 19, 2014 18:46

alexcrichton force-pushed the compiler-flags branch from 2c23def to 117984b Compare December 19, 2014 19:39

bors merged commit 117984b into rust-lang:master Dec 20, 2014

flaper87 mentioned this pull request Dec 21, 2014

Cargo and rustc have inconsistent version flags #17938

Closed

HeroesGrave mentioned this pull request Dec 21, 2014

Cargo always fails because the command to get rustc version has changed. rust-lang/cargo#1073

Closed

This was referenced Dec 21, 2014

--emit=ir is listed as valid choice in manual, but rustc does not accept it anymore #20111

Closed

Update the manual page with new options #20129

Merged

pnkfelix reviewed Dec 22, 2014
View reviewed changes

alexcrichton deleted the compiler-flags branch December 22, 2014 16:07

utkarshkukreti mentioned this pull request Dec 23, 2014

Cargo and rustc have inconsistent version flags rust-lang/cargo#690

Closed

aturon mentioned this pull request Jan 8, 2015

Stabilization for 1.0-alpha2 #20761

Closed

38 tasks

rookwood101 mentioned this pull request Jan 25, 2015

Linter fails with new version of rustc oschwald/SublimeLinter-contrib-rustc#9

Closed

aturon mentioned this pull request Feb 18, 2015

Stabilization for 1.0-beta #22500

Closed

91 tasks

ZoeyR mentioned this pull request Mar 12, 2015

Support Cargo AtomLinter/linter-rust#5

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rustc: Start "stabilizing" some flags #19900

rustc: Start "stabilizing" some flags #19900

alexcrichton commented Dec 16, 2014

alexcrichton commented Dec 16, 2014

sinistersnare commented Dec 16, 2014

emberian commented Dec 16, 2014

emberian commented Dec 16, 2014

sinistersnare commented Dec 16, 2014

mdinger commented Dec 16, 2014

pnkfelix commented Dec 17, 2014

pnkfelix commented Dec 17, 2014

pnkfelix Dec 22, 2014

alexcrichton Dec 22, 2014

pnkfelix commented Dec 22, 2014

alexcrichton commented Dec 22, 2014

pnkfelix commented Dec 22, 2014

rustc: Start "stabilizing" some flags #19900

rustc: Start "stabilizing" some flags #19900

Conversation

alexcrichton commented Dec 16, 2014

alexcrichton commented Dec 16, 2014

sinistersnare commented Dec 16, 2014

emberian commented Dec 16, 2014

emberian commented Dec 16, 2014

sinistersnare commented Dec 16, 2014

mdinger commented Dec 16, 2014

pnkfelix commented Dec 17, 2014

pnkfelix commented Dec 17, 2014

pnkfelix Dec 22, 2014

Choose a reason for hiding this comment

alexcrichton Dec 22, 2014

Choose a reason for hiding this comment

pnkfelix commented Dec 22, 2014

alexcrichton commented Dec 22, 2014

pnkfelix commented Dec 22, 2014