Fixes for various shortcomings of regionck #16319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cro rather than if_ok!
|
@pnkfelix re-running make check reveals some errors, so there are definitely a few minor problems here, possibly rebase failures. Anyway, shouldn't be anything too major. |
|
Never mind, I decided I don't need these to land just yet. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 15, 2024
fix: Differentiate between vfs config load and file changed events Kind of fixes rust-lang/rust-analyzer#14730 in a pretty bad way. We need to rethink the vfs-notify layer entirely. For a decent fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #5527 I found various shortcomings in regionck where it failed to infer regions that would be needed for later checks to pass. I also did some refactoring on the inference code. This PR contains just those bug fixes and refactorings.
r? @pnkfelix