Implement Hash and PartialOrd for RingBuf #16020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| elt.hash(state); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I think in general collections need to hash their length first because otherwise this would have the same hash:
(vec![1], vec![2, 3])(vec![1, 2], vec![3])
There was a problem hiding this comment.
Interesting, I didn't' think of that. That means that some of the other Hash implementations I've done are wrong. TreeMap at least seems to be wrong. Though I'm wondering if that could be fixed at the tuple-level. (Tuples could hash the index before each value?)
I've fixed it for RingBuf here.
There was a problem hiding this comment.
Ah I think it's ok, they can be amended in the future. Hashing to the same value isn't really the end of the world, so long as the comparisons are correct!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #15294