Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: Accept LLVM 3.4.X during configuration #13216

Merged
merged 1 commit into from
Mar 31, 2014

Conversation

alexcrichton
Copy link
Member

The previous regex was a bit to strict, rejecting versions such as 3.4.1 which
is apparently the version which travis is currently installing, causing all
travis builds to fail.

The previous regex was a bit to strict, rejecting versions such as 3.4.1 which
is apparently the version which travis is currently installing, causing all
travis builds to fail.
bors added a commit that referenced this pull request Mar 31, 2014
…sfackler

The previous regex was a bit to strict, rejecting versions such as 3.4.1 which
is apparently the version which travis is currently installing, causing all
travis builds to fail.
@bors bors closed this Mar 31, 2014
@bors bors merged commit 9f990f7 into rust-lang:master Mar 31, 2014
@alexcrichton alexcrichton deleted the fix-configure-for-travis branch March 31, 2014 04:26
notriddle pushed a commit to notriddle/rust that referenced this pull request Sep 20, 2022
…_arg, r=DesmondWillowbrook

New assist: move_format_string_arg

The name might need some improving.

```rust
fn main() {
    print!("{x + 1}");
}
```
to
```rust
fn main() {
    print!("{}"$0, x + 1);
}
```

fixes rust-lang#13180

ref to rust-lang#5988 for similar work

* extracted `format_like`'s parser to it's own module in `ide-db`
* reworked the parser's API to be more direct
* added assist to extract expressions in format args
Jarcho pushed a commit to Jarcho/rust that referenced this pull request Aug 24, 2024
Add a test for ice-3717.rs

this PR is a part of rust-lang/rust-clippy#13099.

Based on the changes introduced in rust-lang#13098 for introduce ui_test, we will update the uitest output.
This is a fix for `ice-3717.rs`.

Although fixes have already been made in rust-lang#13216, it seems that he is a first-time contributor.
I thought it might be better for him to refer to my PR, so I created it accordingly.

Since this is my first contribution in a while, please let me know if there are any issues or required changes.

changelog: none

r! `@flip1995`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants